Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU4 Issue] Mixer and timeline should be tabbed by default, and height adjustment interaction needs fixing #10477

Closed
bkunda opened this issue Feb 7, 2022 · 4 comments · Fixed by #10874
Assignees
Labels
P1 Priority: High
Milestone

Comments

@bkunda
Copy link

bkunda commented Feb 7, 2022

Describe the bug
Opening the timeline before the mixer stacks the two panels rather than tabbing them together.
There is also some glitchy interaction when resizing these panels vertically.

See this video:
(N.B: In the video, when I say "docked" by default, I actually mean "tabbed". Docking is already working as default behaviour).
https://www.dropbox.com/s/fx3jlv5ny2ewfwz/mixer-timeline-docking-issue.mov?dl=0

Expected behavior

  1. Mixer and timeline should be tabbed by default when both are opened (regardless of the order in which they are opened)
  2. Vertical height of these panels when tabbed should be the same as that of the mixer by default (when opened by itself)
  3. The user should be able to change the height of the tabbed panels up to the maximum value currently specified for the mixer, and without any glitches.

Platform information

  • MacOS 12.1 (M1)
  • Windows 11

Additional context
Relates to #9241

@bkunda bkunda added the P1 Priority: High label Feb 7, 2022
@bkunda bkunda added this to Needs triage in [MU4.0 ALPHA2] via automation Feb 7, 2022
@RomanPudashkin RomanPudashkin added this to the Sprint 63 milestone Mar 21, 2022
RomanPudashkin added a commit to RomanPudashkin/MuseScore that referenced this issue Mar 23, 2022
@vpereverzev vpereverzev modified the milestones: Sprint 63, Sprint 64 Apr 4, 2022
RomanPudashkin added a commit to RomanPudashkin/MuseScore that referenced this issue Apr 6, 2022
@DmitryArefiev
Copy link
Contributor

Fixed in #10874

@DmitryArefiev
Copy link
Contributor

@bkunda It seems to be fine but can you check it briefly on 1 OS please? (in PRs build or later in master)

Thank you!

@bkunda
Copy link
Author

bkunda commented Apr 7, 2022

@bkunda It seems to be fine but can you check it briefly on 1 OS please? (in PRs build or later in master)

Thank you!

Looking at this now...

@bkunda
Copy link
Author

bkunda commented Apr 7, 2022

Tested PR in #10874 in MacOS. FIXED.

[MU4.0 ALPHA2] automation moved this from Needs triage to Closed Apr 7, 2022
RomanPudashkin added a commit that referenced this issue Apr 7, 2022
[MU4] Fix #10477: Mixer and timeline should be tabbed by default, and height adjustment interaction needs fixing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Priority: High
Projects
No open projects
[MU4.0 ALPHA2]
  
Closed
4 participants