[MU4 Issue] Wrong OK/Save/Yes buttons order in dialogs on Windows (uses Mac style)

[DmitryArefiev]

Describe the bug
MU4 windows builds now using Mac style for OK/Cancel buttons order in dialogs.
It should be changed to Windows style - OK/Save/Yes buttons should be from the left side

MU4:

MU3:

Expected behavior
OK/Save buttons should be from the left side (See MU3 (or other Win app) to compare)

Platform information
Windows 10

Additional context
Doesn't occur in MU3

Some dialogs have the right order:
Style, Page settings, Add/Remove system breaks, Transpose

Another dialogs with the wrong order:
New Score wizard, Export, Score properties, Parts, Reset palette

[Jojo-Schmitz]

I believe this doesn't happen in MU3 because it got fixed there, some time after 3.x got split off of master

[vihaanthora]

Hello @DmitryArefiev, I wanted to know if this is the case with every dialog in MU4 or just the ones that you have shown as examples in the issue?
Thank you

[cbjeukendrup]

There is generally no handling for the different order on Windows. So it will be wrong in all dialogs.

[Jojo-Schmitz]

Well, that depends on how the dialog is made. Only those using OK, CANCEL etc. buttons directly rather than a QDialogButtonBox have it potentially wrong (from the back of my head, might not be 100% correct)

[cbjeukendrup]

Ah, yes, dialogs in QWidgets that are using QDialogButtonBox will be correct. But other QWidget dialogs and in all QML dialogs, it will be wrong.

[Jojo-Schmitz]

See c9bea53, which fixed this in 3.x (and for 3.6.0), via PR #7084 and also listed in issue #6079, errnously(?) marked as being ported.

[DmitryArefiev]

Hello @DmitryArefiev, I wanted to know if this is the case with every dialog in MU4 or just the ones that you have shown as examples in the issue? Thank you

@vihaanthora @cbjeukendrup I've found there are some dialogs that have the right order:
Style, Page settings, Add/Remove system breaks, Transpose

Another dialogs with the wrong order:
New Score wizard, Export, Score properties, Parts

(Description updated)

[Jojo-Schmitz]

Score properties is amongst those I fixed for 3.x ;-)

[HemantAntony]

@DmitryArefiev it seems like some dialogs also have wrong/different orders for yes and no. For example, Revert to Factory Settings and Reset Palette Dialogs. Worth creating a separate issue for this?

[cbjeukendrup]

@HemantAntony It's indeed worth mentioning, but actually it's just a general problem with more or less all dialog buttons, so one general issue like this is enough.

[DmitryArefiev]

@DmitryArefiev it seems like some dialogs also have wrong/different orders for yes and no. For example, Revert to Factory Settings and Reset Palette Dialogs. Worth creating a separate issue for this?

@HemantAntony Thanks for catching! I'll just add those details to the description.

btw I see wrong/different orders for yes and no only for Reset Palette Dialog and not for Revert to Factory Settings

[HemantAntony]

@DmitryArefiev does the Yes/No button order also depend on the OS?

[DmitryArefiev]

@DmitryArefiev does the Yes/No button order also depend on the OS?

@HemantAntony Yes,

• on Mac: 'Yes' should be from the right
• on Win: 'Yes' should be from the left

Also, you can compare with MU3 on Windows (expected result)

[DmitryArefiev]

Fixed in #11646

[Tantacrul]

Moving to 4.x. Will reopen when 4.0 is out. There are issues with the PR that need extra work to resolve.

[cbjeukendrup]

Reopening, otherwise people start filing duplicates because they can't find it (which already happened in #15570, which contains some additional info by the way)

[Jojo-Schmitz]

Came up again in https://musescore.org/en/node/349101

[Jojo-Schmitz]

Check https://musescore.org/en/node/354139#comment-1205896 how bad this wrong order is recieved by the community

[DmitryArefiev]

Fixed in #19429