-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MU4 Issue] [Workspaces] Workspace Name Character Limit #11362
Comments
I suggest a cap of 24 characters. A user should not be able to enter more than that in the text field. |
@HemantAntony - wondering if you'd like this too? |
I'll take a look! |
The workspace name is checked according to // Check for trailing periods or spaces
if (fn.back() == '.' || fn.back() == ' ') {
return false;
}
// Check for pathnames that are too long
if (fn.size() > 96) {
return false;
} The error in the first image is due to trailing space, and not due to length. Of course the code also shows that the max length is actually 96. Hmmm... should we modify the path.cpp or the newworkspacemodel.cpp? |
Fixed in #14288 |
Describe the bug
There is an ambiguous error when typing reeeeeeeeaaaaaallly long Workspace names.
It could be better to give a fixed character limit prompt to the user instead of "cannot be used".
To Reproduce
Steps to reproduce the behavior:
Note: trying to test the limits of this, i did ignore the warning and was able to get it to accept it. Surprisingly, nothing broke with such a long name.
Expected behavior
A warning that tells that workspace name should be less than X characters.
Screenshots
![Screen Shot 2022-04-25 at 6 54 19 PM](https://user-images.githubusercontent.com/30370609/165127646-647df4c9-6424-491b-84d0-57613e84437a.png)
![Screen Shot 2022-04-25 at 6 55 18 PM](https://user-images.githubusercontent.com/30370609/165127666-7e544881-cca5-4c85-ac07-b957980cbb25.png)
![Screen Shot 2022-04-25 at 6 55 34 PM](https://user-images.githubusercontent.com/30370609/165127684-4849c313-47f0-4a78-a911-9a69e51c61ec.png)
Platform information
OS: macOS 12.2, Arch.: x86_64
MuseScore version (64-bit): 4.0.0-2214419458
revision: github-musescore-musescore-df96a36
The text was updated successfully, but these errors were encountered: