Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The title frame should not scale with general staff size #12685

Closed
mike-spa opened this issue Aug 5, 2022 · 4 comments · Fixed by #23852
Closed

The title frame should not scale with general staff size #12685

mike-spa opened this issue Aug 5, 2022 · 4 comments · Fixed by #23852
Assignees
Labels
engraving P2 Priority: Medium

Comments

@mike-spa
Copy link
Contributor

mike-spa commented Aug 5, 2022

(I've been meaning to post this for a while, please let me know if it's a duplicate. Also, it isn't really a MU4 issue, this seems to be identical in 3.6. Probably not a priority atm, just a bit of clumsiness. @oktophonie @Tantacrul )

Describe the bug
The title frame should not scale with staff size, otherwise text placement is messed up and the music can end up colliding with the title (see video). Consider that, since this PR, staff size reduction may also happen at score creation, which means the user is directly presented with a messed up first page. Not ideal. (Maybe the solution is as simple as using a text frame - rather than a vertical frame - to create the title? Those don't scale with staff size, if I'm not mistaken.)

To Reproduce

  1. Create a score.
  2. Reduce staff size from page settings.

Expected behavior
I think the title frame should retain the original size regardless of document staff size.

Video

Untitled.score.2022-08-05.10-04-26.mp4
@mike-spa
Copy link
Contributor Author

mike-spa commented Aug 5, 2022

Here's an example of recreating the title using text frames instead of vertical frames. I think this is closer to the expected behavior.

Untitled.score.2022-08-05.11-11-00.mp4

@HemantAntony
Copy link
Contributor

From what I remember from working on frames, the title frame is an Horizontal frame whose parent is the first measure. This could explain why this behaviour occurs. Maybe someone can use this as a clue?

@Tantacrul Tantacrul added the P2 Priority: Medium label Aug 15, 2022
@Tantacrul Tantacrul added this to To do in 4.x SHORTLIST via automation Aug 15, 2022
@Tantacrul Tantacrul added this to To do in [MU4.0 - ENGRAVING] via automation Aug 15, 2022
@Tantacrul Tantacrul added this to To do in 4.x LONGLIST via automation Aug 15, 2022
@Tantacrul Tantacrul removed this from To do in 4.x SHORTLIST Aug 15, 2022
@Tantacrul Tantacrul removed this from To do in [MU4.0 - ENGRAVING] Aug 15, 2022
@Tantacrul

This comment was marked as resolved.

@Tantacrul Tantacrul closed this as not planned Won't fix, can't repro, duplicate, stale Aug 15, 2022
4.x LONGLIST automation moved this from To do to Requests Aug 15, 2022
@oktophonie oktophonie reopened this Jun 13, 2023
4.x LONGLIST automation moved this from Requests to In progress Jun 13, 2023
@oktophonie oktophonie removed this from In progress in 4.x LONGLIST Jun 13, 2023
@MarcSabatella
Copy link
Contributor

Although it's true in 3.6.2 also, I just realized it's rather more annoying in MU4 because by default there is a subtitle, thus guaranteeing it will stick out below the frame. With no subtitle, it's not obviously bad that the frame resizes.

The title frame is not a horizontal frame; it's a vertical frame. And it doesn't have the first measure as a parent; it's place before the first measure in the list of MeasureBases (frames and measures share the same MeasureBase base class).

FWIW, using a text frame for title info is not an option because they can contain only a single text element. Also, vertical frames containing ordinary (scaling) text probably should scale with spatium. But frames containing non-scaling text like titles should not. And what if there is a mix of scaling and non-scaling texts in the same frame? I'm not sure it makes sense to try to sort that out. I propose there simply be a new "Match staff size" property on vertical frames like there is for text. This should be set false normally but set true on the automatically-generated title frame. That will be the correct behavior most of the time, and the user can override when it isn't.

@oktophonie oktophonie changed the title [MU4 Issue] The title frame should not scale with general staff size The title frame should not scale with general staff size Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engraving P2 Priority: Medium
Projects
Development

Successfully merging a pull request may close this issue.

6 participants