Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU4 Issue] DOWNLOAD_SOUNDFONT fails silently in presence of connectivity issues #13051

Open
HadrienG2 opened this issue Aug 28, 2022 · 0 comments
Labels
P3 Priority: Low

Comments

@HadrienG2
Copy link

Describe the bug
If the build host has no internet connectivity, then the DOWNLOAD_SOUNDFONT feature of the CMake build system will fail silently.

To Reproduce
Steps to reproduce the behavior:

  1. Clone the git repository or download and unpack a source tarball
  2. Turn off internet connection
  3. Run the build
  4. Build seems to proceed normally, but it actually uses the soundfont bundled into the repository, not the latest version from the mirrors as one would expect

Expected behavior
The build configuration should fail with a clear error message in this configuration. If people want to take care of the soundfont download themselves, then they should turn the DOWNLOAD_SOUNDFONT CMake feature off.

Screenshots
N/A

Platform information
Should be reproducible on any supported build host.

Additional context
This bug was already present in MuseScore 3.6.2, and stems from how the soundfont download feature is implemented in CMake, which has not changed significantly in 4.x. If the first VERSION file download fails (SF_VERSION_DL_STATUS is not 0), then the script exits silently with no console output.

@cbjeukendrup cbjeukendrup added the P3 Priority: Low label Feb 12, 2023
@cbjeukendrup cbjeukendrup added this to To do in 4.x SHORTLIST via automation Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Priority: Low
Projects
Status: One of the next releases
4.x SHORTLIST
  
To do
Development

No branches or pull requests

2 participants