Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU4 Issue] Shortcuts mapped to special characters using shift + numbers do nothing #14195

Open
Fristover opened this issue Oct 30, 2022 · 13 comments · Fixed by #14293
Open

[MU4 Issue] Shortcuts mapped to special characters using shift + numbers do nothing #14195

Fristover opened this issue Oct 30, 2022 · 13 comments · Fixed by #14293
Assignees
Labels
P1 Priority: High

Comments

@Fristover
Copy link

Fristover commented Oct 30, 2022

Changing any shortcut to a special character that uses shift + a number gets detected in the shortcuts menu but doesn't do anything in the actual score, causing default shortcuts like "Toggle Natural (=, Shift + 0)", "Add grace note: Acciaccatura (/, Shift + 7)", "Add parentheses to element (Shift + 9)" and others to be broken

Steps to reproduce the behavior:

  1. Open any score
  2. Use a shortcut like the ones mentioned before
  3. See error

Expected behavior
Those shortcuts should work

Platform information

  • OS: Windows 11, Latin American Spanish keyboard

Additional context
Can reproduce in (at least) US english, ES spanish and LAA spanish.

Various shortcuts get affected in lots of keyboards because many languages use shift + numbers to access special characters like =, (, ), /, $, ~ and many others

@Tantacrul Tantacrul added the P2 Priority: Medium label Nov 1, 2022
@Tantacrul
Copy link
Contributor

@DmitryArefiev - I've run out of time today. Could you verify this issue and assign as appropriate? Thanks!

@MarcSabatella
Copy link
Contributor

I can verify it's an issue for me on Linux and on Windows (both US QWERTY layout), and as a result the defaullt shortcut "(" for bracketing a note doesn't work (it's Shift+9). That's the only one we currently use that requires Shift+number on US QWERTY.

In the past we generally avoided using Shift+number as default shortcuts because they are known to be problematic on some layouts, like French AZERTY, where you need Shift just to get ot the numbers at all. But they've never been problematic on US QWERTY before.

@DmitryArefiev DmitryArefiev added this to To triage in [MU4.0 RELEASE] via automation Nov 1, 2022
@DmitryArefiev DmitryArefiev assigned Eism and unassigned DmitryArefiev Nov 1, 2022
@DmitryArefiev
Copy link
Contributor

Yes, can reproduce it on Mac and Win as well.

Shift+9 doesn't work for adding parentheses. Or another way is assigning Shift+8 (*) for adding accent.
All that works in MS3

bandicam.2022-11-01.17-48-10-120.mp4

@Tantacrul Tantacrul added this to To do in Keyboard navigation and shortcuts via automation Nov 1, 2022
@Tantacrul Tantacrul moved this from To triage to Medium Priority in [MU4.0 RELEASE] Nov 1, 2022
Eism added a commit to Eism/MuseScore that referenced this issue Nov 3, 2022
@Eism
Copy link
Contributor

Eism commented Nov 3, 2022

After some research on the problem, I figured out why the '(' shortcut does not work on Windows and Mac.

On Windows, the problem appears if you register both shortcuts 'Shift+9' and '('. Strange, but it looks like a bug in qt, reproduced on a clean project with only these shortcuts.

On mac, there is a different problem, because there is another solution for registering shortcuts. Looks like another qt bug - for the character '(', qt returns the key of the character '9' without a modifier. So, for the character '(' a '9' shortcut is registered.

In both cases, we depend on the behaviour of qt.
So far I see the only solution is to use 'Shift+9' instead of '('.

The problem with character assing instead of splitting into a modifier+key should be solved as part of a separate task.

@Tantacrul Tantacrul removed this from Medium Priority in [MU4.0 RELEASE] Nov 3, 2022
@Tantacrul Tantacrul added this to To do in 4.x SHORTLIST via automation Nov 3, 2022
@Tantacrul
Copy link
Contributor

I'm going to move this to post-beta unless anyone has any strong objection. It feels annoying but we have bigger fish to fry than this one.

@MarcSabatella
Copy link
Contributor

Isn't it already post-beta? :-) Anyhow, not super pressing indeed - but if it's connected to why numpad doesn't work, that might bump its priority for a lot of people.

@Eism - as I mentioned, it's also a problem for me on Linux, so I'm not sure whether it needs the same fix as Windows, or same as macOS, or if it needs yet a different fix.

@Tantacrul
Copy link
Contributor

Tantacrul commented Nov 3, 2022

I moved it to Post Beta as I made that comment. It had previously been in release.

Keyboard navigation and shortcuts automation moved this from To do to Done Nov 7, 2022
Eism added a commit that referenced this issue Nov 7, 2022
fixed #14195: Using Shift+number instead of character
4.x SHORTLIST automation moved this from To do to Done Nov 7, 2022
@DmitryArefiev DmitryArefiev reopened this Nov 8, 2022
Keyboard navigation and shortcuts automation moved this from Done to In progress Nov 8, 2022
4.x SHORTLIST automation moved this from Done to In progress Nov 8, 2022
@MarcSabatella
Copy link
Contributor

Current status seems to be that (predefined shortcuts using Shift+number work - so, "(" - which is Shift+9 - works, as do the tab duration shortcuts. But I can't define my own.

@Fristover
Copy link
Author

that might be US case but here predefined ones don't work either

@marczellm
Copy link

My usecase for this would be to set Shift+2 as the shortcut for "Enter second interval below" etc.

@raphj
Copy link

raphj commented Mar 25, 2023

Adding to this:

To input a dot on an AZERTY keyboard, one need to type Shift+dot . In MuseScore that would allow entering a dotted note, this does not work.

Shift+1 to Shift+7 (to input 1 to 7) to change the note length works, except Shift+6 (for the half note). Not sure this is related to this bug.

These issues make it quite tedious to input basic scores with an AZERTY keyboard without numeric keys on MuseScore (Linux)

@LouisTP
Copy link

LouisTP commented Dec 16, 2023

Hey,

I wanted to stress the importance of this issue, we encountered it numerous times with Windows users on laptops with AZERTY layout (without numpads) :

Adding to this:

To input a dot on an AZERTY keyboard, one need to type Shift+dot . In MuseScore that would allow entering a dotted note, this does not work.

Shift+1 to Shift+7 (to input 1 to 7) to change the note length works, except Shift+6 (for the half note). Not sure this is related to this bug.

These issues make it quite tedious to input basic scores with an AZERTY keyboard without numeric keys on MuseScore (Linux)

Is it worth creating a whole new ticket to adress this ? Are you by any chance already working on a fix ?
It would reassure my students (and me !), thanks a lot 😀

@Tantacrul Tantacrul added P1 Priority: High and removed P2 Priority: Medium labels Dec 16, 2023
@Skelbti
Copy link

Skelbti commented Dec 19, 2023

Actually, the whole experience with a laptop AZERTY keyboard on MuseScore is bad, Windows or macOS. There are too many issues to be usable. Maybe we should open a clear issue to address this main problem for french users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Priority: High
Projects
4.x SHORTLIST
  
In progress
Development

Successfully merging a pull request may close this issue.

9 participants