Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU4 Issue] Playback not in sync with playhead when changing instrument in mixer #15047

Closed
bkunda opened this issue Dec 8, 2022 · 10 comments · Fixed by #20626
Closed

[MU4 Issue] Playback not in sync with playhead when changing instrument in mixer #15047

bkunda opened this issue Dec 8, 2022 · 10 comments · Fixed by #20626
Assignees
Labels
muse sounds P1 Priority: High playback General playback issue

Comments

@bkunda
Copy link

bkunda commented Dec 8, 2022

Describe the bug
Note: similar to #14894, but with a different trigger

When substituting instruments in the mixer and then resuming playback mid-score, the substituted instrument alone recommences playback from the start of the score (concurrently with the playback at playhead position).

To Reproduce
See demo video:
https://www.dropbox.com/s/mx9ymh9rtbfihax/playback-sync-position-change.mov?dl=0

Expected behavior
Substituted instrument should not recommence playback from start, but should instead sync with current playhead position.

Platform information

  • macOS 12.6 (M1)
  • RC (4.0.0.223411003)
@bkunda bkunda added the P1 Priority: High label Dec 8, 2022
@bkunda bkunda added this to To do in [MU4 - AUDIO] via automation Dec 8, 2022
@bkunda bkunda added this to To do in 4.x SHORTLIST via automation Dec 8, 2022
@bkunda bkunda added this to To do in [MU4 - MPE] via automation Dec 8, 2022
@pmarx810
Copy link

pmarx810 commented Dec 8, 2022

@Tantacrul @bkunda Very similar to #14902 , could be duplicate

@pmarx810
Copy link

pmarx810 commented Dec 8, 2022

@Tantacrul @MarcSabatella @RomanPudashkin also similar to the issue found in #14910

@bkunda
Copy link
Author

bkunda commented Dec 9, 2022

Thanks @pmarx810, all these issues do indeed seem very similar to one another.
I'll keep this one open for now though because it contains a demo video, which is always useful for our devs so they can actually see what's going on.
Thanks!

@MarcSabatella
Copy link
Contributor

@Tantacrul this one comes up often and I assume it would be a simple fix to consider for a patch

@cbjeukendrup
Copy link
Contributor

@Tantacrul this one comes up often and I assume it would be a simple fix to consider for a patch

@Tantacrul This would indeed be good. Not sure how simple it is (although it can't be too complicated), but it would certainly be nice to get this fixed since it has come up quite a few times.

@cbjeukendrup cbjeukendrup added this to Needs Triage in [MU4.0.2 PATCH-RELEASE] via automation Jan 29, 2023
@Tantacrul
Copy link
Contributor

I'd like to hear what @vpereverzev has to say.

Patch or 4.1?

@bkunda
Copy link
Author

bkunda commented Aug 31, 2023

@DmitryArefiev can you please check this one again for validity/reproducibility?

@DmitryArefiev
Copy link
Contributor

DmitryArefiev commented Aug 31, 2023

@bkunda Yes, still occurs (4.2 nightly master, MuseSounds, Win10).

Can't reproduce with MS Basic

@bkunda
Copy link
Author

bkunda commented Nov 17, 2023

Also from #14894:

Steps to reproduce the behavior:

Play a score with the current instrument
Stop the playback, don't change position of the play head
Change instrument
Start playback.
Playback starts at the beginning of the score, while play head continues from current position somewhere in the score.

RomanPudashkin added a commit to RomanPudashkin/MuseScore that referenced this issue Dec 21, 2023
since we're not working with the position from AbstractEventSequencer
(AbstractEventSequencer::eventsToBePlayed isn't called, so we don't update it)
@DmitryArefiev
Copy link
Contributor

Fixed in #20626

[MU4 - AUDIO] automation moved this from To do to Done Jan 8, 2024
[MU4 - MPE] automation moved this from To do to Done Jan 8, 2024
rettinghaus pushed a commit to rettinghaus/MuseScore that referenced this issue Jan 8, 2024
since we're not working with the position from AbstractEventSequencer
(AbstractEventSequencer::eventsToBePlayed isn't called, so we don't update it)
RomanPudashkin added a commit to RomanPudashkin/MuseScore that referenced this issue Jan 9, 2024
since we're not working with the position from AbstractEventSequencer
(AbstractEventSequencer::eventsToBePlayed isn't called, so we don't update it)
RomanPudashkin added a commit to RomanPudashkin/MuseScore that referenced this issue Jan 9, 2024
since we're not working with the position from AbstractEventSequencer
(AbstractEventSequencer::eventsToBePlayed isn't called, so we don't update it)
zacjansheski pushed a commit to zacjansheski/MuseScore that referenced this issue Feb 13, 2024
since we're not working with the position from AbstractEventSequencer
(AbstractEventSequencer::eventsToBePlayed isn't called, so we don't update it)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
muse sounds P1 Priority: High playback General playback issue
Projects
[MU4 - AUDIO]
  
Done
[MU4 - MPE]
  
Done
MuseScore 4.1
  
To triage
Status: Done
Development

Successfully merging a pull request may close this issue.

10 participants