Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU4 Issue] Custom interface font settings don't apply to top menu bar #15187

Closed
ghost opened this issue Dec 15, 2022 · 13 comments
Closed

[MU4 Issue] Custom interface font settings don't apply to top menu bar #15187

ghost opened this issue Dec 15, 2022 · 13 comments
Labels
by design The behaviour is intentional. It's not a bug; it's a feature!

Comments

@ghost
Copy link

ghost commented Dec 15, 2022

Describe the bug

The settings under Preferences - Appearance - Appearance (Font face and Body text size) don't apply to the top menu bar of MuseScore.

To Reproduce

  1. Open MuseScore 4
  2. Go into Preferences - Appearance - Appearance
  3. Change Font face to a non system default font (for example, Comic Sans MS)
  4. Change Body text size to 18pt

Expected behavior

Just as the rest of UI, the top menu bar should also renders using the custom font face, and using bigger font size.

Screenshots

bug

Platform information

  • OS: Windows 10

Additional context

This behavior is especially bad for Chinese locales on Windows, or any other locale + OS combination that Qt decided to choose a bad default font with.

Here is a screenshot of MuseScore in Simplified Chinese locale:

bug_cn

I choose Microsoft YaHei (微软雅黑) for Font face, and it does apply to other parts of the UI. The menu bar still renders using the simsun (宋体) font, which is very ugly, and super blurry in this case. Since font size setting doesn't apply to menu bar either, there is no way to make this more readable, other than changing language.

(Microsoft YaHei is actually the real system default UI font for Simplified Chinese in Windows 10, not simsun.)

Similar problem in Traditional Chinese:

bug_cn_t

@qaziquza
Copy link

You seriously had to pick comic sans as your example font, yes? There wasn't any other one in the world available? (I kid, of course)

In all seriousness, this is a rather major issue. I hope it gets fixed soon.

@Leonerd-04
Copy link

Can confirm this also happens on Linux.

I also hope this gets fixed soon, as the smaller font face is much harder for me to make out.

@Eism
Copy link
Contributor

Eism commented Dec 15, 2022

Fixed Font face is by design. see #8090 and #10214

@Tantacrul @jessjwilliamson what do you think about font size?

@Tantacrul
Copy link
Contributor

Yes, we don't want to be interfering with the top menu, I'm afraid.

@Tantacrul Tantacrul added the by design The behaviour is intentional. It's not a bug; it's a feature! label Dec 15, 2022
@ghost
Copy link
Author

ghost commented Dec 15, 2022

Fixed Font face is by design.

Use native OS font for Windows (Segoe UI)

If the goal is to match native Windows default UI font for title bar, this is still a problem (at least for Chinese users), because the actual system default UI fonts in Windows 10 are not what showed in 2 screenshots in Additional context. In fact, I'm trying to force MuseScore to use the real system default UI font manually.

Also, I will argue that letting users to change the font for this is a good idea anyway, especially when they already want to customize UI font. Adding this option doesn't prevent us from making the default settings default.

@ghost
Copy link
Author

ghost commented Dec 15, 2022

@Tantacrul I think this issue should be re-opened, as it describes that behaviors in some locales didn't match with the design goals stated in #8090.

@Tantacrul
Copy link
Contributor

It's not getting reopened. Please do not bother us with this any further.

@cbjeukendrup
Copy link
Contributor

cbjeukendrup commented Dec 15, 2022

@Tantacrul There turns out to be a bug, so we can't say it's by design. Yes, it is by design that the menu bar uses the system font. But that's broken for Chinese locales. Apparently, the system font on Windows is not Segoe UI for these locales, but something else (Microsoft YaHei as mentioned?). So Chinese users will see the wrong font in their menu bar, namely not the Chinese system font.

I can't tell how bad it is for Chinese users to see something other than the system font even though we intended to show them the system font, but in principle we should support all locales equally well.

(Probably should be discussed in a new issue though, since this issue was originally about customizing the font of the menu bar, which is indeed disabled by design, I don't argue with that.)

@ghost
Copy link
Author

ghost commented Dec 15, 2022

@cbjeukendrup

Apparently, the system font on Windows is not Segoe UI for these locales, but something else (Microsoft YaHei as mentioned?).

Yes, on Windows 10, Microsoft YaHei is the default UI font for Simplified Chinese. For Traditional Chinese, it's Microsoft Jhenghei.

I can't tell how bad it is for Chinese users to see something other than the system font even though we intended to show them the system font, but in principle we should support all locales equally well.

See replies under this tweet, there are other users that are disgusted by this font as well.

@cbjeukendrup
Copy link
Contributor

Okay, so to be fair, it is more an aesthetic problem (just awful) than a functional (completely unreadable). That lowers the priority somewhat.

One more question, when launching MS4 for the first time (or when reverting to factory settings), does it also use the wrong font for the rest of the app?

@ghost
Copy link
Author

ghost commented Dec 16, 2022

@cbjeukendrup It does use the wrong font for the whole app:

bug_default

It's actually using Segoe UI, but since Segoe UI doesn't include CJK characters, I think it triggers Qt's font fallback to use simsun for Chinese, or something.

segoe

@cbjeukendrup
Copy link
Contributor

cbjeukendrup commented Dec 16, 2022

Okay, thanks. I propose to open a new issue about MuseScore choosing the incorrect system font for Chinese (and possibly other locales), so that we can leave this issue behind us.

@lorenzosu
Copy link

lorenzosu commented Dec 30, 2022

Hi,
I'm experiencing this issue with Musescore 4.0.0 on KDE Plasma 5.26.4 - This is the repository version installed on Manjaro.
Qt version as reported by Musescore itself is 5.15.7.

I have set the font size in the Appearance settings to 14px but this doesn't seem to be picked in many parts of the UI... Essentially it would seem only in the 'tabs' (Home, Score, Publish) at the top (?)
See screenshots below.

Note that I have set the 'menu' font in KDE Plasma font settings to Noto Sans 12 but this is not the case in Musescore.
The display resolution is 1920x1080 with 'global scale' at 100%.

If Musescore is using its own style for the UI and not picking up system settings it might be useful to look into how other application in a similar situation approach this; for example Ardour (which I believe uses its own styled / modified GTK), has a global 'scale' parameter and recently introduced this as the fist option when first started, which makes sense because if everything is too small it might even be difficult for the user to actually find the setting to scale up fonts and UI.

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
by design The behaviour is intentional. It's not a bug; it's a feature!
Projects
None yet
Development

No branches or pull requests

6 participants