-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MU4 Issue] The date macros ($d, $D, $M) for header/footer show the dates in US format (MM/DD/YY) #15437
Comments
Tried with
OS: Linux |
Not so on my Windows 11. System, Language and Date settings all in German, MuseScore date shows in US format And it isn't just me but also the user from https://musescore.org/de/node/339004 |
Confirmed on Windows 10 21H2 (19044.2251): even after explicitly setting MS4 to German the dates are still in US format. |
Confirmed on Windows 10 too. Date is always in US format |
I see the code differences, but my cpp skills are too limited to draw the right conclusions from what I see... version 4: MuseScore/src/engraving/libmscore/page.cpp Line 463 in 9055e97
version 3.6.2: Line 357 in 4566605
|
So an issue in MuseScore's own string lib? |
As said: I don't have a clue of cpp so I cannot judge.... |
A bit of background: the reason that we are not using Qt anymore for this, is that we don't want our engraving library to depend on such a specific and huge framework as Qt, which is primarily used for building user interfaces. To mention one advantage: without this huge dependency, it becomes much easier to use our library in other applications, if anyone would ever want that. Another is that our engraving module is safe when a new major version of Qt is released, or if Qt suddenly quits its open source licenses, like they are already doing for LTS releases. |
For me it would be sufficient to have a possibility to specify my preferred date & time format somewhere (e.g. close to the language setting in general preferences). |
If not configurable or as per locale, ISO format is the only right and sensible choice (and US format being the worst and wrongest choice). Also that, and only that, should be in used on musescore.com, i.e. by the backend. |
After uprgading my scores to version 4, I'm being bitten by this bug too, with the wrong date being displayed (for my locale - day and month in wrong order). I would ideally like to see:
Of these, number 4 is the most important. With number 4, it is possible to write a date in a locale-independent way (e.g. Y-m-d), which would make it possible to work around the problem of determining the user's locale problem, which sounds like more of a challenge. It would hopefully be a simple partial fix. |
The choice of the US format is the worst of all... |
@cbjeukendrup : any chance to quickly change the default format to ISO (yyyy-MM-dd) instead of LocaleShortFormat? MuseScore/src/engraving/libmscore/page.cpp Line 463 in 9055e97
That would for sure be an excellent workaround for all non-US users - a really quick win with minimal effort. |
Yes, ISO would be the very least thing to do here. At least for a 4.0.2. |
Let's try that. See #15906. @Tantacrul This seems indeed appropriate for 4.0.2 (and is low risk anyway) |
Temp fix #15437: Use ISO date format instead of locale which doesn't work
Reopening awaiting a proper solution for 4.1 |
Came up again in https://musescore.org/en/node/342785 |
Hasn't this fix made it into 4.0.2? |
Based on @cbjeukendrup's comment, I'd say 'no'. |
That comment shouldn't indicate that, just that for 4.1 a more complete solution is wanted than the simple ISO date one for 4.0.2. |
I must admit, this one was handled by other folk, so I think I'll wait for someone who was involved to comment. Apologies, just a little busy so can't quite take time to look. |
@Tantacrul The plan was to put a low-risk trivial fix in 4.0.2, and work on a more complicated fix for 4.1. According to the history of this thread, I communicated this back then, and you added it to the 4.0.2 project accordingly. But then there was a misunderstanding/whatever: the fix for 4.0.2 had been merged to master, and you moved the issue to the 4.1 project, awaiting the promised proper fix, but at that point the fix intended for 4.0.2 had not yet been cherry-picked to the 4.0.2 branch. And because the issue had been removed from the 4.0.2 project, that never happened anymore, unfortunately. Let's hope that the months until 4.1 will pass quickly :) |
Ah, well sorry if this seems rather convoluted. It is entirely likely that someone on the dev team asked me to move it for some reason. At least if it is assigned to 4.1, we still have the task prepared to be worked on. |
Anything happening on this? |
I too am annoyed by the US format even though it has a logic of its own ... Thanks for the background info, I now appreciate more the convolutions that go with this seemingly small issue. |
Describe the bug
The date macros ($d, $D, $M) for header/footer show the dates in US format (MM/DD/YY)
Expected behavior
Same as MuseScore 3 and before: obey MuseScore's language settings or the computer's regional settings
As an alternative (and the least thing to do) use the ISO format, YYYY-MM-DD
The text was updated successfully, but these errors were encountered: