Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU4 Issue] Save to cloud should check for corruption before attempting to upload (and refuse in case of corruption) #15857

Closed
Jojo-Schmitz opened this issue Jan 13, 2023 · 7 comments
Assignees
Labels
needs design Design is needed P1 Priority: High

Comments

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Jan 13, 2023

Describe the bug
Save to cloud should check for corruption before attempting to upload (and refuse in case of corruption)

To Reproduce
Steps to reproduce the behavior:

  1. Take a corrupt score (one that Mu4 reports as corrupted, the forum is full of them).
  2. Save it online.
  3. It does get saved, sort of.
  4. But once finished on musescore.com, there an error gets reported:
Oops! Score download has stopped due to an unexpected error. Please try again.
If the error occurs, please contact our Support Team.
Thank you for understanding!

Expected behavior
Check for corruption priod to attempt to upload, and don't upload if it is corrupt.
MuseScore 3 (and 2) behaved like that.
Becomes more important with Mu4 because of the lengthy MP3 generation, resp. the time that gets wasted with that.

Platform information

  • OS: Window (but I don't think other platforms behave differently here).

Additional context
Came up in https://musescore.org/en/node/341658

@Tantacrul Tantacrul added this to To do in [MU4.0.2 PATCH-RELEASE] via automation Jan 13, 2023
@Tantacrul Tantacrul added the needs design Design is needed label Jan 13, 2023
@Tantacrul
Copy link
Contributor

Definite Patch Release fix. Adding @shoogle and @bkunda to work out the specifics.

@Tantacrul Tantacrul added the P1 Priority: High label Jan 13, 2023
@Jojo-Schmitz
Copy link
Contributor Author

Jojo-Schmitz commented Jan 13, 2023

Esp. in connection with #15226 / #11807 and their fixes. Should use the same check and dialog.

@Jojo-Schmitz
Copy link
Contributor Author

Seems to have missed 4.0.1?

@shoogle
Copy link
Contributor

shoogle commented Jan 13, 2023

There will be at least one more patch release before 4.1, so no need to delay the important fixes in 4.0.1 waiting for this one, which requires design work as well as development work.

@Tantacrul
Copy link
Contributor

Yes, I added it to 4.0.2.

There are a few more things we want to fix, but it will take a little more time. Patch 4.0.1 is mainly to fix the worst corruption and crash problems. We didn't want to delay that and were already doing final testing on it yesterday.

@Jojo-Schmitz
Copy link
Contributor Author

Ok, understood, thanks

@cbjeukendrup cbjeukendrup moved this from Needs Triage to Important in [MU4.0.2 PATCH-RELEASE] Jan 16, 2023
@RomanPudashkin
Copy link
Contributor

See #16042

[MU4.0.2 PATCH-RELEASE] automation moved this from To do to Done Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs design Design is needed P1 Priority: High
Projects
None yet
Development

No branches or pull requests

5 participants