Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MU4 Task] New corrupted file dialogs #16042

Closed
bkunda opened this issue Jan 24, 2023 · 0 comments · Fixed by #16151
Closed

[MU4 Task] New corrupted file dialogs #16042

bkunda opened this issue Jan 24, 2023 · 0 comments · Fixed by #16151
Assignees
@Eism
Labels
P1 Priority: High
Projects
[MU4.0.2 PATCH-RELEASE]

Comments

@bkunda
Copy link

bkunda commented Jan 24, 2023

Task description
Two parts to this task:

  1. This new dialog would be triggered when the user attempts to save/publish a score to the cloud that was already corrupted upon opening:

Group 14189

  1. These new dialogs would be triggered if the user tries to save a "clean" (i.e. non-corrupted) score, which has become corrupted since it was opened:

Version where the user attempts a save to the cloud
Group 14192

Version where the user attempts a local save
Group 141932

In both cases, "revert to last saved" triggers this confirmation dialog:
Group 14194

Figma files have been sent directly to @Eism.
@shoogle @cbjeukendrup @Tantacrul FYI

Thanks!
@bkunda bkunda added the P2 Priority: Medium label Jan 24, 2023
@bkunda bkunda added this to Needs Triage in [MU4.0.2 PATCH-RELEASE] via automation Jan 24, 2023
@Eism Eism moved this from Needs Triage to Important in [MU4.0.2 PATCH-RELEASE] Jan 26, 2023
@RomanPudashkin RomanPudashkin added P1 Priority: High and removed P2 Priority: Medium labels Jan 30, 2023
@RomanPudashkin RomanPudashkin mentioned this issue Jan 30, 2023
Closed
@RomanPudashkin RomanPudashkin moved this from To do to In progress in [MU4.0.2 PATCH-RELEASE] Jan 30, 2023
Eism added a commit to Eism/MuseScore that referenced this issue Jan 31, 2023
@Eism
fixed musescore#16042: Show corrupted message before saving
5efce80
Eism added a commit to Eism/MuseScore that referenced this issue Jan 31, 2023
@Eism
fixed musescore#16042: Show corrupted message before saving
bbc4616
@Eism Eism mentioned this issue Jan 31, 2023
Merged
Eism added a commit to Eism/MuseScore that referenced this issue Jan 31, 2023
@Eism
fixed musescore#16042: Show corrupted message before saving
32f0211
Eism added a commit to Eism/MuseScore that referenced this issue Feb 1, 2023
@Eism
fixed musescore#16042: Show corrupted message before saving
b6d5086
Eism added a commit to Eism/MuseScore that referenced this issue Feb 1, 2023
@Eism
fixed musescore#16042: Show corrupted message before saving
0b35d51
Eism added a commit to Eism/MuseScore that referenced this issue Feb 1, 2023
@Eism
fixed musescore#16042: Show corrupted message before saving
abbdf37
@RomanPudashkin RomanPudashkin moved this from In progress to Needs Testing in [MU4.0.2 PATCH-RELEASE] Feb 1, 2023
Eism added a commit to Eism/MuseScore that referenced this issue Feb 2, 2023
@Eism
fixed musescore#16042: Show corrupted message before saving
796022a
@RomanPudashkin RomanPudashkin moved this from Needs Testing to In progress in [MU4.0.2 PATCH-RELEASE] Feb 6, 2023
Eism added a commit to Eism/MuseScore that referenced this issue Feb 7, 2023
@Eism
fixed musescore#16042: Show corrupted message before saving
c62588e
@Eism Eism moved this from In progress to Needs Testing in [MU4.0.2 PATCH-RELEASE] Feb 7, 2023
Eism added a commit to Eism/MuseScore that referenced this issue Feb 10, 2023
@Eism
fixed musescore#16042: Show corrupted message before saving
4ffe433
Eism added a commit to Eism/MuseScore that referenced this issue Feb 10, 2023
@Eism
fixed musescore#16042: Show corrupted message before saving
581430c
Eism added a commit to Eism/MuseScore that referenced this issue Feb 10, 2023
@Eism
fixed musescore#16042: Show corrupted message before saving
2fafdf9
[MU4.0.2 PATCH-RELEASE] automation moved this from Needs Testing to Done Feb 10, 2023
RomanPudashkin pushed a commit to RomanPudashkin/MuseScore that referenced this issue Feb 10, 2023
@Eism @RomanPudashkin
fixed musescore#16042: Show corrupted message before saving
fe6b218
@RomanPudashkin RomanPudashkin moved this from Done to Needs Porting in [MU4.0.2 PATCH-RELEASE] Feb 10, 2023
RomanPudashkin pushed a commit to RomanPudashkin/MuseScore that referenced this issue Feb 10, 2023
@Eism @RomanPudashkin
fixed musescore#16042: Show corrupted message before saving
630261f
@RomanPudashkin RomanPudashkin moved this from Needs Porting to Done in [MU4.0.2 PATCH-RELEASE] Feb 10, 2023
@bkunda bkunda mentioned this issue Feb 14, 2023
Closed
@abariska abariska moved this from Done to Done - Tested Again in [MU4.0.2 PATCH-RELEASE] Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Eism Eism

Labels
P1 Priority: High
Projects
No open projects
[MU4.0.2 PATCH-RELEASE]
Done - Tested Again
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[MU4] Check for corruption before attempting to save Eism/MuseScore
3 participants
@Eism @RomanPudashkin @bkunda