[MU4 Issue] Drumset selection playback, wrong instruments

[MekaSergal]

Describe the bug
When picking which part of the drumset to play at the bottom of the page, the clicked drum part makes the sound of a different one.

Edit from @bkunda: the conditions for incorrect playback are that a transposing instrument needs to be in the score above the drumset stave, and "concert pitch" needs to be toggled OFF. Note it only affects note input playback, not regular playback.

To Reproduce
Steps to reproduce the behavior:

1. Create score with alto saxophone and drumset.
2. Change saxophone clef to "Treble clef 8va alta"
3. Using the default note input tool, double click on a measure of the drumset to bring up the note selection menu at the bottom of the page.
4. Click on any of the drum sounds and see (hear) that they don't match.

Expected behavior
Drum part clicked makes corresponding drum sound

Platform information

• OS: Windows 10

Found while making this:
Sister Marian.zip

[MarcSabatella]

Note: the issue seems to be caused by the transposing instrument at the top of the score. Somehow it is causing the playback of the drum palette to also be affected. If you switch to concert pitch, save, and reload, the problem goes away.

[MarcSabatella]

There was a related by in an earlier 3.x release but fixed for 3.5 - not on behavior for preview specifically, but for double-click. See https://musescore.org/en/node/291522. This was fixed for 3.5 in #6094. Not sure if this is related or not, but it could be useful info. Since this is coming up pretty often and it seems likely to be a small fix, I'll continue looking into it.

[MarcSabatella]

So far no luck figuring out where the problem is. First couple of things I tried didn’t work. I’d love someone else to take a look - I suspect with a working build environment & debugger it would be pretty simple to track down. I’m thinking that code adjusting TPC on read is probably not the issue, it’s probably more in the code to play the selected element and it’s using the staff index 0 but grabbing transposition info from staff 0 of the actual score instead of the palette score.

[MarcSabatella]

I see this is on the list for 4.x but not 4.1. It is actually one of the most commonly-reported bugs still outstanding. @sammik does this seem like something you might be able to take a look at, or at least help me track down (see the info I posted above)?

[sammik]

I see this is on the list for 4.x but not 4.1. It is actually one of the most commonly-reported bugs still outstanding. @sammik does this seem like something you might be able to take a look at, or at least help me track down (see the info I posted above)?

@MarcSabatella please, check and test #17674

[MarcSabatella]

@sammik works great, thanks so much!

[bkunda]

Thanks for this @sammik! I've left some notes on your PR to get it tested and reviewed for merging, so hopefully this can be done soon (from my own brief testing, it does seem to have solved the problem 🙂).