Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdowns, menus and lists should highlight items in reaction to key presses ("Initial Letter Navigation") #16508

Open
cbjeukendrup opened this issue Feb 23, 2023 · 12 comments
Assignees
Labels
accessibility Issues related to accessibility community Issues we would like the community to address P2 Priority: Medium task

Comments

@cbjeukendrup
Copy link
Contributor

cbjeukendrup commented Feb 23, 2023

Task description
When a dropdown, menu or list is focused, you should be able to type text on the keyboard, to quickly jump to the corresponding item.

For example, in the dropdown shown below,

  • when you press S, it should highlight the first item that comes lexicographically after "S", so in this case "Sans Serif Collection".

  • when you press S E in quick succession, it should highlight the first item that comes lexicographically after "Se", so in this case "Segoe Fluent Icons".

  • when you press S G in quick succession, it should highlight the first item that comes lexicographically after "Sg", so in this case "Showcard Gothic".

Technical note
This will need to be implemented for all QML dropdowns/menus/lists/treeViews.
In Qt Widgets, this already works out of the box (and for those few cases where it doesn't, we shouldn't invest time to fix it since Qt Widgets is going to be replaced eventually anyway).

@cbjeukendrup cbjeukendrup added the community Issues we would like the community to address label Feb 23, 2023
@cbjeukendrup cbjeukendrup added this to To do in 4.x LONGLIST via automation Feb 23, 2023
@cbjeukendrup cbjeukendrup added this to Triage in MS4.X Design Tasks via automation Feb 23, 2023
@Tantacrul
Copy link
Contributor

I agree. I also think you've basically designed it, so no input required from me. Let's do it!

@Tantacrul Tantacrul removed their assignment Feb 23, 2023
@Tantacrul Tantacrul removed this from Triage in MS4.X Design Tasks Feb 23, 2023
@Tantacrul Tantacrul added the P2 Priority: Medium label Feb 23, 2023
@octopols

This comment was marked as off-topic.

@cbjeukendrup

This comment was marked as off-topic.

@cbjeukendrup cbjeukendrup added accessibility Issues related to accessibility task labels Nov 4, 2023
@cbjeukendrup cbjeukendrup changed the title [MU4 Task] Dropdowns, menus and lists should highlight items in reaction to key presses Dropdowns, menus and lists should highlight items in reaction to key presses ("Initial Letter Navigation") Nov 4, 2023
@jmwmusic
Copy link

jmwmusic commented Nov 5, 2023

Really hope this one can be addressed as it is standard accessibility practice and makes a significant difference to productivity. Take for example adding the swing item from the tempo palette, currently that takes 31 down arrow presses to get to!

@Tantacrul

This comment was marked as resolved.

@jmwmusic

This comment was marked as resolved.

@cbjeukendrup

This comment was marked as resolved.

@jmwmusic
Copy link

jmwmusic commented Nov 9, 2023

Can I check whether the scope of this issue currently includes palette lists, and if not can that be added?

@jmwmusic
Copy link

I think this might be related - Currently screen reader is not announcing the Mnemonic Shortcut options in menus. So for example in the File menu if you arrow down to Open it just says "Open Ctrl O" but would usually say "Open Ctrl O O". But maybe this is deliberate till it is working as currently if I press Alt F O I get stuck in nomans land with no focus, tab & arrow do not work and I have to press Esc to get out of it.

@cbjeukendrup
Copy link
Contributor Author

I think the Mnemonics issue is unrelated, and it would be preferable to have a separate issue for that. MuseScore uses a custom menu implementation on Windows, so speech for mnemonic shortcuts was probably just not implemented. However, mnemonics themselves should be working correctly. If not, that would be a regression and would deserve an issue on its own.

@re1san
Copy link
Contributor

re1san commented Jan 16, 2024

Hey, I would like to work on it :)

@scorster
Copy link

scorster commented Apr 4, 2024

Issue reported here on .org, along with issues with the Up arrow keystroke.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Issues related to accessibility community Issues we would like the community to address P2 Priority: Medium task
Projects
4.x LONGLIST
  
To do
Status: Tentatively in progress
Development

No branches or pull requests

6 participants