Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Musicxml Export] - Tablature staff (linked) doesn't export -> import from musescore 4 -> musescore 3 properly in some cases #17481

Closed
mike-hoegeman opened this issue May 6, 2023 · 19 comments
Closed

[Musicxml Export] - Tablature staff (linked) doesn't export -> import from musescore 4 -> musescore 3 properly in some cases #17481

mike-hoegeman opened this issue May 6, 2023 · 19 comments
Assignees
@bkunda @DmitryArefiev
Labels
needs review The issue needs review to set priority, fix version or change status etc.

Comments

@mike-hoegeman
Copy link

Issue type

Other type of issue

Bug description

i have a score in musescore4 that has a linked tablature staff that i'd like to give to a friend that has musescore 3 ( he has an ancient mac) if i export it to musicxml it mostly works, but it doesn't preserve the the fingering changes i made in the tablature staff. it seems to just have in there what it makes as default guesses when you first create the score. any suggestions on how to work around that. there doesn't seem to be a way to unlink the staffs before export. i would likely be happy enough to just export the (correct tabs) only also. i tried deleting the notation staff but that doesn't work because the tab staff still acts like it's linked

the musescore 3 is 3.6.2 btw
musescore 4 is 4.0.2

this musescore 4 score demonstrates the issue
Variations_for_the_healing_of_Arinushka_no_six.mscz.zip

MarcSabatella — Today at 12:30 PM
If the notation staff is deleted, then there is no more linking, so it can't really be that the tab staff is acting like it's linked - more likely it's a limitation of either MuseScore 4 MusicXML export, or MuseScore 3 MusicXML import
I just did a little test, though, and it all worked fine for me, so in order to say more, we'd need to see your score
MarcSabatella — Today at 12:52 PM
I can confirm that for some reason this score isn't working even though the test I created did
So, please open an issue on GitHub and attach the score there for further investigation

Steps to reproduce

  1. export attached file in musicxml format from musescore 4 ( has linked tablature staffs )
  2. import file into musescore 3
  3. notice that the tablature in the imported score in musescore 3 has incorrect fret / string values. they are not the ones present in the original musescore 4 score

Screenshots/Screen recordings

No response

MuseScore Version

the musescore 3 is 3.6.2 musescore 4 is 4.0.2

Regression

I don't know

Operating system

macos ventura 13.3.1

Additional context

No response
@muse-bot muse-bot added the needs review The issue needs review to set priority, fix version or change status etc. label May 6, 2023
@mike-hoegeman mike-hoegeman changed the title MusicXml export: Tablature staff (linked) doesn't export -> import from musescore 4 -> musescore properly in some cases [MusicXml Export] Tablature staff (linked) doesn't export -> import from musescore 4 -> musescore properly in some cases May 6, 2023
@mike-hoegeman mike-hoegeman changed the title [MusicXml Export] Tablature staff (linked) doesn't export -> import from musescore 4 -> musescore properly in some cases [Musicxml Export] - Tablature staff (linked) doesn't export -> import from musescore 4 -> musescore properly in some cases May 6, 2023
@mike-hoegeman mike-hoegeman changed the title [Musicxml Export] - Tablature staff (linked) doesn't export -> import from musescore 4 -> musescore properly in some cases [Musicxml Export] - Tablature staff (linked) doesn't export -> import from musescore 4 -> musescore 3 properly in some cases May 7, 2023
@lvinken
Copy link
Contributor

lvinken commented May 7, 2023

There are a number of different issues at play here:

@mike-hoegeman
Copy link
Author

mike-hoegeman commented May 7, 2023 via email

@lvinken
Copy link
Contributor

lvinken commented May 8, 2023

PR 17490 only fixes the last of the three issues.

@bkunda
Copy link

bkunda commented May 8, 2023

For what it's worth, I was able to export the file provided in the issue description as MusicXML and import it into Sibelius more or less correctly (there remains some fiddliness with stave transposition to address, and also the bass stave seems to be inverted in MS4, which Sibelius doesn't pick up – and I'm not even sure how to achieve this is MS4. But these inconsistencies notwithstanding, the fingering is at least not altered like it is when opening in MS3).

I too tested with other scores, and can confirm export/import is working as expected. So it seems there is something unusual going on in this particular score when bringing it into MS3.

So unless this can be reproduced across other scores, it's not really an issue, but rather a particular problem with this score.

(That's not to say there isn't an issue lurking deeper behind the scenes here, but in order to be an effective issue that we can act upon, some more thorough troubleshooting would be needed to generalise the problem before it gets raised here).

Since both Marc and I have been able to successfully export tab and import it into MS3 with correct fingerings (aside from the attached score), I'm going to close this issue for now so it doesn't distract our dev team. I'd also add that the title is incredibly confusing, which isn't helping here. If @mike-hoegeman you are able to reproduce this in other contexts, then I think we'd stand a better chance of identifying an issue that we can address. Meanwhile, there may be other members on our Discord channel or the forum who can help you further troubleshoot your score. I can certainly appreciate how frustrating it is that the fingering isn't being imported correctly!

@bkunda bkunda closed this as not planned Won't fix, can't repro, duplicate, stale May 8, 2023
@lvinken
Copy link
Contributor

lvinken commented May 9, 2023

@bkunda, please see my previous remarks, they describe structural issues. I'll submit separate and specific issues for these (and probably also provide pull requests with fixes).

@mike-hoegeman
Copy link
Author

mike-hoegeman commented May 9, 2023 via email

@lvinken
Copy link
Contributor

lvinken commented May 14, 2023 •
edited
Loading

The main issue in transferring MusicXML tab generated by MuseScore 4 from the attached file to MuseScore 3 (causing the incorrect fingerings) is that MuseScore 3 (and MuseScore 4 up to 4.0.2) do not support importing non-standard tab staff tuning (due to a bug). Note that the export of tab with non-standard tuning was already correct as was the import of standard tuning.

Meanwhile import of non-standard staff tuning has been fixed in MuseScore 4 by PR 17490. To solve the transfer to MuseScore 3 problem, this fix must be ported to MuseScore 3.

@bkunda
Copy link

bkunda commented May 15, 2023

Thank you @lvinken for looking into this further. Am I right in understanding that the issue was in the main a result of importing non-standard staff tuning (fixed by #17490)?.

Were there any other issues that specifically concern MuseScore 4?

To solve the transfer to MuseScore 3 problem, this fix must be ported to MuseScore 3.

Just to be clear, we aren't going to be releasing any official updates to MuseScore 3, so the internal team won't be making any fixes for this problem in anything other than the current version.

@mike-hoegeman
Copy link
Author

mike-hoegeman commented May 15, 2023 via email

@bkunda
Copy link

bkunda commented May 15, 2023

@mike-hoegeman are you specifically talking about this problem identified by @lvinken?

MuseScore (3 and 4) does not export linked regular/tab parts correctly (the "staff-type alternate" is missing, see https://www.w3.org/2021/06/musicxml40/musicxml-reference/examples/staff-type-element)

If this indeed remains a problem, and it is reproducible (i.e. does not just affect one score), then it would make sense for it to be raised as a separate issue.

@mike-hoegeman
Copy link
Author

mike-hoegeman commented May 15, 2023 via email

@mike-hoegeman
Copy link
Author

mike-hoegeman commented May 15, 2023 via email

@mike-hoegeman
Copy link
Author

mike-hoegeman commented May 15, 2023 via email

@lvinken
Copy link
Contributor

lvinken commented May 17, 2023

@bkunda, indeed IMHO the failure to import non-standard staff tuning (fixed in MuseScore 4 by PR17490) was the most important. I am aware of the MuseScore 3 policy and hope Jojo will pick this up in his fork. Until that happens there is no easy way to move tab files with non-standard staff tuning from MuseScore 4 to MuseScore 3.

Yes, the other two issues mentioned in my May 7 reply are indeed structural issues in MuseScore 3 to MuseScore 4, although I expect their impact is smaller. As soon as I find the opportunity I'll submit separate and specific issues for these (and may also provide pull requests with fixes).

@Jojo-Schmitz
Copy link
Contributor

#17490 has been backported to my branch 3.x about a week ago

@bkunda
Copy link

bkunda commented May 17, 2023

As soon as I find the opportunity I'll submit separate and specific issues for these (and may also provide pull requests with fixes).

That's great, thank you @lvinken

@lvinken
Copy link
Contributor

lvinken commented May 26, 2023

@bkunda, indeed IMHO the failure to import non-standard staff tuning (fixed in MuseScore 4 by PR17490) was the most important. I am aware of the MuseScore 3 policy and hope Jojo will pick this up in his fork. Until that happens there is no easy way to move tab files with non-standard staff tuning from MuseScore 4 to MuseScore 3.

Yes, the other two issues mentioned in my May 7 reply are indeed structural issues in MuseScore 3 to MuseScore 4, although I expect their impact is smaller. As soon as I find the opportunity I'll submit separate and specific issues for these (and may also provide pull requests with fixes).

@lvinken
Copy link
Contributor

lvinken commented May 26, 2023

Submitted issue 17737 for MusicXML import and export of a linked staff.

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented May 26, 2023 •
edited
Loading

I will pick this up for my fork

Actually #17490 is already in, since some 2 weeks, as noted above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bkunda bkunda

@DmitryArefiev DmitryArefiev

Labels
needs review The issue needs review to set priority, fix version or change status etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@lvinken @mike-hoegeman @Jojo-Schmitz @muse-bot @bkunda @DmitryArefiev