Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dot position UI no longer works #17749

Closed
Tantacrul opened this issue May 27, 2023 · 4 comments · Fixed by #17988
Closed

Dot position UI no longer works #17749

Tantacrul opened this issue May 27, 2023 · 4 comments · Fixed by #17988
Assignees
@oktophonie @asattely
Labels
engraving P1 Priority: High regression Regression on a prior release

Comments

@Tantacrul
Copy link
Contributor

Issue type

Engraving bug

Bug description

The option to change the dot position (in the inspector panel) is no longer working

image

Steps to reproduce

Create dotted note on a line and try the options in the inspector

Screenshots/Screen recordings

No response

MuseScore Version

4.1

Regression

Yes, this used to work in a previous version of MuseScore 4.x

Operating system

MacOS

Additional context

No response
@muse-bot muse-bot added engraving regression Regression on a prior release labels May 27, 2023
@Tantacrul Tantacrul added the P1 Priority: High label May 27, 2023
HemantAntony added a commit to HemantAntony/MuseScore that referenced this issue May 28, 2023
@HemantAntony
Fix musescore#17749: Dot position UI does not work
b59d891
@HemantAntony HemantAntony mentioned this issue May 28, 2023
Closed
8 tasks
@HemantAntony
Copy link
Contributor

HemantAntony commented May 28, 2023 •
edited

Hey, can you check if #17763 fixes this issue? :)

@Tantacrul
Copy link
Contributor Author

Tantacrul commented May 28, 2023 •
edited

It is definitely producing the result I want! Thanks Hemant! 😄

@RomanPudashkin @Eism @cbjeukendrup - if you're happy with this, can it be inducted into the international merging hall of fame?

@cbjeukendrup
Copy link
Contributor

I think @asattely would be the ideal person to review this PR. (From a pure code-technical POV it looks good, but I don't know the context super well.)

@HemantAntony
Copy link
Contributor

Cool! I have to fix my vtest failures first. I broke a couple things 😅

@asattely asattely mentioned this issue Jun 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oktophonie oktophonie

@asattely asattely

Labels
engraving P1 Priority: High regression Regression on a prior release
Projects
MuseScore 4.1
Status: Done
Milestone
No milestone
7 participants
@muse-bot @oktophonie @Tantacrul @cbjeukendrup @HemantAntony @asattely @mike-spa