Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small staff in multi-staff instrument leads to incorrectly resized instrument name #17891

Closed
mmeyn opened this issue Jun 7, 2023 · 3 comments · Fixed by #19161
Closed

Small staff in multi-staff instrument leads to incorrectly resized instrument name #17891

mmeyn opened this issue Jun 7, 2023 · 3 comments · Fixed by #19161
Assignees
Labels
engraving P2 Priority: Medium

Comments

@mmeyn
Copy link

mmeyn commented Jun 7, 2023

Issue type

Engraving bug

Bug description

This happens only when resizing the uppermost staff of a multi-staff instrument (f. e. right hand of a keyboard instrument).

This scenario is used in Basso Continuo parts for an editorial realization of the BC figures.

Steps to reproduce

  1. Create a new score with a keyboard instrument and at least another instrument.
  2. Resize the upper staff of the keyboard instrument to small staff.

Screenshots/Screen recordings

grafik

MuseScore Version

4.0.2

Regression

I don't know

Operating system

Linux

Additional context

No response

@mmeyn
Copy link
Author

mmeyn commented Jun 8, 2023

Oh, I didn’t say what I expected as correct behaviour: The instrument name of the Cembalo should be the same as Traversflöte, i. e. the font size should match the default staff size whenever there is at least one default sized staff (only when all staves of an instrument are small, the instrument name might be scaled down).

@oktophonie oktophonie added the P2 Priority: Medium label Jul 6, 2023
@oktophonie oktophonie assigned miiizen and unassigned mike-spa Aug 20, 2023
@mmeyn
Copy link
Author

mmeyn commented Aug 24, 2023

The InstrumentName of a multi-staff instrument is not a property of the Part but of the first Staff. In SystemLayout::layoutInstrumentNames it is moved to the first visible SysStaff. I tried to move it to the first SysStaff that is both visible and the corresponding Staff is not Pid::SMALL (if possible, otherwise just to the first visible) but that’s not sufficient because then it’s placed incorrectly.

miiizen added a commit to miiizen/MuseScore that referenced this issue Aug 24, 2023
miiizen added a commit to miiizen/MuseScore that referenced this issue Sep 11, 2023
miiizen added a commit to miiizen/MuseScore that referenced this issue Oct 20, 2023
miiizen added a commit to miiizen/MuseScore that referenced this issue Oct 23, 2023
RomanPudashkin added a commit that referenced this issue Oct 26, 2023
Fix #17891: Instrument names follow largest stave spatium in part
@Jojo-Schmitz
Copy link
Contributor

Same issue in Mu3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engraving P2 Priority: Medium
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

6 participants