Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash after adding thirds on tied notes #18796

Closed
MichLeon opened this issue Jul 25, 2023 · 5 comments · Fixed by #18800
Closed

Crash after adding thirds on tied notes #18796

MichLeon opened this issue Jul 25, 2023 · 5 comments · Fixed by #18800
Assignees
@Eism
Labels
crash Issues involving a crash of MuseScore P0 Priority: Critical regression MS4 Regression on a prior release

Comments

@MichLeon
Copy link

MichLeon commented Jul 25, 2023 •
edited by DmitryArefiev
Loading

Issue type

Crash or freeze

Bug description

No response

Steps to reproduce

In attached score:
1 Select all
2 Press Alt + 3 to create thirds
3 Undo
4 Press Alt + 3 again.
Crash

Image shows loose ties after first Alt+3.
First report on https://musescore.org/en/node/352714

Screenshots/Screen recordings

See comment

MuseScore Version

MU: 4.1.0-231921402, rev: 2e3a93a - MU:: 4.1.1-232050501, rev: dfdbbec - MU: 4.2.0-232050502, rev: 9be710d

Regression

Yes, this used to work in 4.0.2

Operating system

Windows 11

Additional context

Crash_after_adding_thirds.zip
After_Alt+3
Win 11 AMD Ryzen 9 5900X 12 (x2) -Core Processor - AMD RAdeon RX 6700 XT

Related to #16636
@muse-bot muse-bot added the crash Issues involving a crash of MuseScore label Jul 25, 2023
@DmitryArefiev DmitryArefiev added regression MS4 Regression on a prior release P0 Priority: Critical labels Jul 25, 2023
@DmitryArefiev
Copy link
Contributor

There are two issues here that appeared in 4.1.0: broken tie and crash. Occurs not only with thirds.

Easy to reproduce with cases like that:

bandicam.2023-07-25.11-27-21-811.mp4

Also, I found that on some scores the crash occurs right after adding thirds on whole score (also doesn't occur in 4.0.2)

  1. Open Smoke test 15.zip or
    starwars_basic.zip
  2. Ctrl+A
  3. Alt+3
bandicam.2023-07-25.11-42-01-950.mp4

@Tantacrul
Copy link
Contributor

I can replicate the broken tie on MacOS but not the crash. Must be a Windows thing?

image

@DmitryArefiev DmitryArefiev assigned Eism and unassigned mike-spa Jul 25, 2023
@DmitryArefiev
Copy link
Contributor

Some weird things with this bug..

On Mac, I reverted factory settings and got the result you have (no crash)
Restarted MS, now I get the crash again

@cbjeukendrup
Copy link
Contributor

See also #17256 and my comment there at the bottom; that PR might have a solution.

Eism added a commit to Eism/MuseScore that referenced this issue Jul 25, 2023
@Eism
fixed musescore#18796: reset previous tied note after adding tie
0824bfd
@Eism Eism mentioned this issue Jul 25, 2023
Merged
Eism added a commit to Eism/MuseScore that referenced this issue Jul 25, 2023
@Eism
fixed musescore#18796: reset previous tied note after adding tie
bb0bd03
Eism added a commit to Eism/MuseScore that referenced this issue Jul 25, 2023
@Eism
fixed musescore#18796: reset previous tied note after adding tie and …
5dbd65d 
…sort notes by tick
Eism added a commit to Eism/MuseScore that referenced this issue Jul 25, 2023
@Eism
fixed musescore#18796: reset previous tied note after adding tie and …
d761025 
…sort notes by tick
@DmitryArefiev
Copy link
Contributor

Fixed in #18799

Eism added a commit to Eism/MuseScore that referenced this issue Jul 25, 2023
@Eism
fixed musescore#18796: reset previous tied note after adding tie and …
16368fd 
…sort notes by tick
Eism added a commit that referenced this issue Jul 25, 2023
@Eism
Merge pull request #18799 from Eism/tied_notes_crash_fix_4.1.1
29aee24 
fixed #18796: Crash after adding thirds on tied notes
@oktophonie oktophonie mentioned this issue Jul 25, 2023
Merged
Eism added a commit that referenced this issue Jul 25, 2023
@Eism
Merge pull request #18800 from Eism/tied_notes_crash_fix
1072b9e 
fixed #18796: Crash after adding thirds on tied notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Eism Eism

Labels
crash Issues involving a crash of MuseScore P0 Priority: Critical regression MS4 Regression on a prior release
Projects
No open projects
MuseScore 4.1.1
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixed #18796: Crash after adding thirds on tied notes Eism/MuseScore
8 participants
@Eism @muse-bot @Tantacrul @cbjeukendrup @RomanPudashkin @DmitryArefiev @mike-spa @MichLeon