Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add _keyList property to masterscore #18950

Open
sammik opened this issue Aug 6, 2023 · 0 comments
Open

add _keyList property to masterscore #18950

sammik opened this issue Aug 6, 2023 · 0 comments
Labels
feature request Used to suggest improvements or new capabilities P3 Priority: Low

Comments

@sammik
Copy link
Contributor

sammik commented Aug 6, 2023

Your idea

Key signature is (in most cases) global property of system. Local key signature for single staff is exception of this general rule.

So it make sense to have master score _keyList property, where global key signatures are stored.

Similar, like we have _timemap and _tempomap.

It would solve some problems, namely:

  • if first staff has local key signature in place, where global key signature is in score, newly added part copies this local key signature, instead of correct global key signature
wrong-keysig-new-instrument.mp4
  • if all instruments are removed in Instruments tab, key list for score is lost - newly added instrument has no key signatures (but has time signatures)
missing-keylist.mp4

Problem to be solved

Properly define, what "global key signature is", how it is added to score (standard key signature for all staves), how is removed, ...

Rules should be consistent with time signatures (masterscore._timemap).

Prior art

No response

Additional context

Once this FR would be aplied, #18949 wouldn't be relevant anymore and may be reverted.
Some context - #18906.

@muse-bot muse-bot added the feature request Used to suggest improvements or new capabilities label Aug 6, 2023
@oktophonie oktophonie added the P3 Priority: Low label Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Used to suggest improvements or new capabilities P3 Priority: Low
Projects
None yet
Development

No branches or pull requests

3 participants