Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #18906 preserve keyList if removes all instruments #18949

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

sammik
Copy link
Contributor

@sammik sammik commented Aug 6, 2023

preserve keyList if removes all instruments and add diferent one in instruments dialog

Resolves: #18906

score keyList is red from existing staves, but if user removes all staves in instruments dialog, there is nothing to read keyList from.

This PR just simply reads keyList in masternotationparts before removing instruments.

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@RomanPudashkin RomanPudashkin merged commit c1a7925 into musescore:master Aug 14, 2023
11 checks passed
@sammik sammik deleted the fix-missing-keys branch August 14, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Score "loses" key signature when removing last instrument
3 participants