Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MusicXML Import] Crash if stop wavy-line is missing #19322

Closed
tsjam23 opened this issue Sep 7, 2023 · 2 comments · Fixed by #18766
Closed

[MusicXML Import] Crash if stop wavy-line is missing #19322

tsjam23 opened this issue Sep 7, 2023 · 2 comments · Fixed by #18766
Assignees
Labels
crash Issues involving a crash of MuseScore MusicXML needs info More information is required before action can be taken P1 Priority: High

Comments

@tsjam23
Copy link

tsjam23 commented Sep 7, 2023

Issue type

Crash or freeze

Bug description

Musescore crashes if open broken musicxml file where <wavy-line type="stop"> is missing.
I guess every wavy-line should have an ending pair:

<!-- start part-->
<notations>
   <ornaments>
      <trill-mark/>
      <wavy-line type="start" number="1" default-y="12.50"/>
   </ornaments>
</notations>
<!-- some other xml elements -->
<!-- end part -->
<notations>
   <ornaments>
      <wavy-line type="stop" number="1"/>
   </ornaments>
</notations>

But in case end part is missing, Musescore should't crash and somehow handle this situation: ignore ornament or display warning message
It was reported here https://musescore.org/en/node/354428

Steps to reproduce

  1. Download attached sample or real score here
  2. Try to open it with Musescore 4.1.1

Screenshots/Screen recordings

No response

MuseScore Version

MuseScore version (64-bit): 4.1.1

Regression

I don't know

Operating system

Windows 10

Additional context

Sample file to reproduce crash
musicxml_open_crash.zip

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Sep 8, 2023

See #19329

Apparently a regression vs. Mu3

Similar to my PR 3.6.2 seems to ignore that trill without an end.
OTOH my 3.7 does not and gives this debug output:
Debug: Trill ticks changed, -1 -> 480 (...\libmscore\spanner.cpp:668, void Ms::Spanner::computeEndElement())

@bkunda bkunda added the P1 Priority: High label Sep 8, 2023
@bkunda bkunda added the needs info More information is required before action can be taken label Sep 22, 2023
@Jojo-Schmitz
Copy link
Contributor

#18766 fixes this

@cbjeukendrup cbjeukendrup linked a pull request Oct 2, 2023 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crash Issues involving a crash of MuseScore MusicXML needs info More information is required before action can be taken P1 Priority: High
Projects
Status: Done
6 participants