Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GH#19322: [MusicXML Import] Crash if stop wavy-line is missing #19329

Closed
wants to merge 1 commit into from
Closed

Fix GH#19322: [MusicXML Import] Crash if stop wavy-line is missing #19329

wants to merge 1 commit into from

Conversation

Jojo-Schmitz
Copy link
Contributor

Resolves: #19322

@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Sep 8, 2023
Closed
@Jojo-Schmitz Jojo-Schmitz force-pushed the broken-trill-crash branch 2 times, most recently from eb9b620 to b85d63c Compare September 8, 2023 09:24
@Jojo-Schmitz
Copy link
Contributor Author

@RomanPudashkin mind to review?

@cbjeukendrup
Copy link
Contributor

cbjeukendrup commented Oct 2, 2023 •
edited

Note that this code will be removed in #18766, which seems to make this PR obsolete (so, @zacjansheski, please test that one first 🙂)

@Jojo-Schmitz
Copy link
Contributor Author

So #18766 would need to get tested against #19322

@Jojo-Schmitz
Copy link
Contributor Author

I just did, and there's no crash

@Jojo-Schmitz Jojo-Schmitz deleted the broken-trill-crash branch October 2, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomanPudashkin RomanPudashkin RomanPudashkin approved these changes

Assignees

@zacjansheski zacjansheski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[MusicXML Import] Crash if stop wavy-line is missing
4 participants
@Jojo-Schmitz @cbjeukendrup @RomanPudashkin @zacjansheski