Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crescendo, Decrescendo, Pedal lines: text offset does not survive save/reopen #19460

Closed
zacjansheski opened this issue Sep 19, 2023 · 6 comments · Fixed by #19872
Closed

Crescendo, Decrescendo, Pedal lines: text offset does not survive save/reopen #19460

zacjansheski opened this issue Sep 19, 2023 · 6 comments · Fixed by #19872
Assignees
Labels
engraving P2 Priority: Medium regression_ms3 Regression from MS3 (3.6.2)

Comments

@zacjansheski
Copy link
Contributor

Issue type

Engraving bug

Bug description

Pedal text offset does not survive save/reopen

Steps to reproduce

  1. Create a file with Pedal markings with text
  2. Assign new text offset values in the properties panel
  3. Save, close and reopen
  4. Offset value returns to 0

Screenshots/Screen recordings

video1795779190.mp4

MuseScore Version

4.1.1

Regression

No.

Operating system

OS: macOS 11.6

Additional context

Discovered when testing this PR #19454

@mathesoncalum
Copy link
Contributor

There may be more to this than we initially thought @zacjansheski - I discovered the same is happening for diminuendo and other engravings (for beginning, continuing, and end text). Weirdly, this seems to have been a problem for diminuendo since MS3, but Pedals look like a regression since then.

Probably worth figuring out the exact scope of this and when particular aspects were broken.

@zacjansheski
Copy link
Contributor Author

MS3 before save
Screen Shot 2023-09-21 at 10 55 50 AM

After quit and reopen
Screen Shot 2023-09-21 at 10 57 01 AM

@zacjansheski
Copy link
Contributor Author

zacjansheski commented Sep 21, 2023

MS4.0.0 - 4.0.2
(No pedal text offset capability)
Before save
Screen Shot 2023-09-21 at 11 02 24 AM

After close and reopen

Screen Shot 2023-09-21 at 11 02 59 AM

@zacjansheski
Copy link
Contributor Author

4.1.1 Only horizontal offset capabilities

Before save
Screen Shot 2023-09-21 at 11 11 40 AM

After close and reopen

Screen Shot 2023-09-21 at 11 11 58 AM

@zacjansheski zacjansheski changed the title Pedal text offset does not survive save/reopen Crescendo, Decrescendo, Pedal lines: text offset does not survive save/reopen Sep 21, 2023
@zacjansheski zacjansheski added the regression_ms3 Regression from MS3 (3.6.2) label Sep 21, 2023
@zacjansheski
Copy link
Contributor Author

As @mathesoncalum stated:
Pedal Offset lost on save: MS3 regression
Crescendo/Decrescendo Offset lost on save: Not a regression

mathesoncalum added a commit to mathesoncalum/MuseScore that referenced this issue Oct 30, 2023
mathesoncalum added a commit to mathesoncalum/MuseScore that referenced this issue Oct 30, 2023
RomanPudashkin added a commit that referenced this issue Oct 31, 2023
Fix #19460: Write begin, continue, and end text offset properties
@Jojo-Schmitz
Copy link
Contributor

This is a regression vs. Mu3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engraving P2 Priority: Medium regression_ms3 Regression from MS3 (3.6.2)
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

6 participants