Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undo-Redo reveal hidden instruments in parts causes crash #19766

Closed
zacjansheski opened this issue Oct 18, 2023 · 0 comments · Fixed by #20366
Closed

Undo-Redo reveal hidden instruments in parts causes crash #19766

zacjansheski opened this issue Oct 18, 2023 · 0 comments · Fixed by #20366
Assignees
@miiizen
Labels
crash Issues involving a crash of MuseScore P0 Priority: Critical regression Regression on a prior release
Projects
Parts

Comments

@zacjansheski
Copy link
Contributor

Issue type

Crash or freeze

Bug description

Undoing - Redoing the reveal of hidden instruments in a part causes a crash.

Need to use two normal instruments or one linked staff.

No crash in 4.1.1, crashes in master.

Steps to reproduce

  1. Open a part
  2. Reveal two instruments or a linked staff
  3. Undo (2x if two instruments)
  4. Redo (2x if two instruments)

Screenshots/Screen recordings

video1491245901.mp4

MuseScore Version

OS: macOS 11.7, Arch.: x86_64, MuseScore version (64-bit): 4.2.0-232911142, revision: github-musescore-musescore-4c61b2e

Regression

Yes, this used to work in a previous version of MuseScore 4.x

Operating system

All

Additional context

PartCrash.zip
@muse-bot muse-bot added crash Issues involving a crash of MuseScore regression Regression on a prior release labels Oct 18, 2023
@zacjansheski zacjansheski added the P1 Priority: High label Oct 18, 2023
@zacjansheski zacjansheski added this to To do in Parts via automation Oct 18, 2023
@zacjansheski zacjansheski added P0 Priority: Critical and removed P1 Priority: High labels Oct 20, 2023
@cbjeukendrup cbjeukendrup mentioned this issue Nov 20, 2023
Merged
@oktophonie oktophonie assigned miiizen and unassigned cbjeukendrup Nov 30, 2023
miiizen added a commit to miiizen/MuseScore that referenced this issue Dec 8, 2023
@miiizen
Fix musescore#19766 crash
852b7ac
@miiizen miiizen mentioned this issue Dec 8, 2023
Merged
Parts automation moved this from To do to Done Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miiizen miiizen

Labels
crash Issues involving a crash of MuseScore P0 Priority: Critical regression Regression on a prior release
Projects
MuseScore 4.2
Status: Done
Parts
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove segment directly, not via undo miiizen/MuseScore
5 participants
@muse-bot @miiizen @cbjeukendrup @RomanPudashkin @zacjansheski