Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anacrusis obscures bar 1's bar number #20016

Closed
iainhallam opened this issue Nov 13, 2023 · 8 comments · Fixed by #21149 or Jojo-Schmitz/MuseScore#285
Closed

Anacrusis obscures bar 1's bar number #20016

iainhallam opened this issue Nov 13, 2023 · 8 comments · Fixed by #21149 or Jojo-Schmitz/MuseScore#285
Assignees
Labels
community Issues particularly suitable for community contributors to work on engraving feature request Used to suggest improvements or new capabilities good first issue Issues suitable for first-time contributors. See https://github.com/musescore/MuseScore/contribute needs design Design is needed P2 Priority: Medium

Comments

@iainhallam
Copy link

iainhallam commented Nov 13, 2023

Issue type

Engraving bug

Bug description

When I ask bar numbers to appear at every bar in a score that starts with an anacrusis, I don't see a bar number for bar 1, just a hidden object that looks like a small grey rectangle, that presumably implements the bar number change to make the rest of them correct. However, I'd like to see bar 1's number, leaving only the partial bar without a number.

In a score without an anacrusis, bar 1's number should not be shown.

I've started polls in a barbershop Discord server (5:2 in favour of showing bar 1's number) and an engravers' group on Facebook (https://www.facebook.com/groups/musicengravingtips/posts/3276402939325242 - 86% in favour of showing bar 1's number in this case). One of the commenters on the Facebook post said, "I'd say, no bar-line, no number... First bar-line, first number.", which I thought summed up my approach fairly succinctly.

Steps to reproduce

  1. Create a score with an anacrusis
  2. Set bar numbers to appear at interval 1, rather than every system

Screenshots/Screen recordings

2023-11-13 Musecore 4 1 1 bar number anacrusis

Bar 2 correctly has a number shown, but none for bar 1, where I'd like to see a "1".

MuseScore Version

MuseScore version (64-bit): 4.1.1-232071203, revision: github-musescore-musescore-e4d1ddf

Regression

I don't know

Operating system

OS: Windows 10 Version 2009 or later, Arch.: x86_64

Additional context

No response

@iainhallam
Copy link
Author

Here's the image I used on the polls:

2023-11-13 bar number anacrusis

Option A is so far winning by a country mile.

@MarcSabatella
Copy link
Contributor

MarcSabatella commented Nov 13, 2023

The "-" you see isn't a bar number; it's an indication that the preceding bar has fewer beats than the time signature calls for (in other words, it's a pickup). It's just for on-screen display as a reminder, and can be disabled via the View menu - just like the icons for system breaks etc.

The display of measure numbers for the first measure is not really common in my experience, but I can certainly see it might make sense for scores that a) have numbers on all measures, and b) have a pickup. So, simply enable the "Show first" option in Format / Style / Measure numbers. You can also force display of measure numbers in any measure via Measure properties.

In the future, please ask in the Support forum on musescore.org when you have questions about MuseScore. Then if something is confirmed to be a bug or if a consensus developers that there is a missing feature, this issue tracker is the place to go next.

@iainhallam
Copy link
Author

The "-" you see isn't a bar number; it's an indication that the preceding bar has fewer beats than the time signature calls for (in other words, it's a pickup). It's just for on-screen display as a reminder, and can be disabled via the View menu - just like the icons for system breaks etc.

Thanks for the info.

The display of measure numbers for the first measure is not really common in my experience, but I can certainly see it might make sense for scores that a) have numbers on all measures, and b) have a pickup. So, simply enable the "Show first" option in Format / Style / Measure numbers. You can also force display of measure numbers in any measure via Measure properties.

Thanks also for the workaround of measure properties. In general, though, if there are multiple movements, one wouldn't want to set a style for the whole file to always show the numbers for the first bar.

In the future, please ask in the Support forum on musescore.org when you have questions about MuseScore. Then if something is confirmed to be a bug or if a consensus developers that there is a missing feature, this issue tracker is the place to go next.

I've done that for several items where there seemed to be discussion to be had, or it was that I didn't know where to find things, but even with a workaround, this seemed to me to be a fairly clear, if low-priority, bug; even lower now that a workaround is documented on it.

@sammik
Copy link
Contributor

sammik commented Nov 14, 2023

I think, core of issue is different.
"Hide first measure number" should hide measure number of "first measure in score", and not number of "measure number 1".
See:
bar_numbers

Fixing that fixes also this "pickup measure" issue.

I think it is easy one. Good candidate for comunity good first issue.

@bkunda bkunda self-assigned this Nov 14, 2023
@bkunda bkunda added feature request Used to suggest improvements or new capabilities needs design Design is needed labels Nov 14, 2023
@bkunda bkunda added this to To do in 4.x SHORTLIST via automation Nov 14, 2023
@bkunda bkunda added the P2 Priority: Medium label Nov 14, 2023
@cbjeukendrup cbjeukendrup added good first issue Issues suitable for first-time contributors. See https://github.com/musescore/MuseScore/contribute community Issues particularly suitable for community contributors to work on labels Dec 8, 2023
@srinivaspavan9
Copy link

Hi,
I am interested in this issue and so like to help resolve it. However I am unable to setup the project. I have forked the repo, cloned it and downloaded all the dependencies and then opened the folder in visual studio, now I am struck I am not understanding how to how to run/ build the project in development mode. I need help.

@cbjeukendrup
Copy link
Contributor

@srinivaspavan9 Welcome! You may find the information at https://github.com/musescore/MuseScore/wiki/Set-up-developer-environment useful, as well as the pages linked in the sidebar on that page under "Compilation".

If you have any more questions, the best place to ask is the MuseScore Developers Discord Server.

@Rohan-here
Copy link

@bkunda could you assign me this issue

@worldwideweary
Copy link
Contributor

Maybe I'm trippin', but I still see bar numbers on the anacrusis after this, and not only that, but for example still seeing the first "normal" measure as measure number 2 instead of what seems like the OP's desire for it to be number 1.

image

instead of the above mentioned desired:

image

and then to make it funnier, @Jojo-Schmitz pointed out that there's a problem with a measure number not showing after a section-break under certain circumstances: #21730 (comment) and it seems to be a result from this PR

The PRs: #20141 + #21730 have been tested so far to be a.o.k save for that.
Hope this helps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Issues particularly suitable for community contributors to work on engraving feature request Used to suggest improvements or new capabilities good first issue Issues suitable for first-time contributors. See https://github.com/musescore/MuseScore/contribute needs design Design is needed P2 Priority: Medium
Projects
Status: Done
9 participants