Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MU4 Issue] Checkmarks missing from MS Basic soundfonts menus #20233

Closed
avvvvve opened this issue Nov 28, 2023 · 1 comment · Fixed by #20316
Closed

[MU4 Issue] Checkmarks missing from MS Basic soundfonts menus #20233

avvvvve opened this issue Nov 28, 2023 · 1 comment · Fixed by #20316
Assignees
@mathesoncalum
Labels
Design debt To be used for small bits of jank that shouldn't take much developer time to fix mixer Issues relating to the Mixer UI Visual issues affecting the UI (not notation)

Comments

@avvvvve
Copy link

avvvvve commented Nov 28, 2023 •
edited

Issue type

UI bug (incorrect info or interface appearance)

Bug description

Checkmarks are missing from the SoundFonts submenu tree for MS Basic sounds. If a user has never manually changed an MS Basic sound, "Choose automatically" should be checked on, as well as "MS Basic" in the menu above it. Currently, it appears as if no selection has been made.

Steps to reproduce

  1. Make sure MS Basic is set as the playback profile
  2. Open the mixer
  3. Click the sound dropdown on a channel strip (it should say "MS Basic")
  4. Hover over SoundFonts
  5. See that MS Basic is not checked (it should be)
  6. Hover over MS Basic
  7. See that "Choose automatically" is not checked (it should be)

Screenshots/Screen recordings

image

MuseScore Version

MuseScore version (64-bit): 4.2.0-233310507, revision: github-musescore-musescore-c6bc567

Regression

No.

Operating system

OS: macOS 14.1, Arch.: x86_64

Additional context

No response
@avvvvve avvvvve added UI Visual issues affecting the UI (not notation) Design debt To be used for small bits of jank that shouldn't take much developer time to fix mixer Issues relating to the Mixer labels Nov 28, 2023
@avvvvve
Copy link
Author

avvvvve commented Nov 28, 2023

@jessjwilliamson tagging for visibility :)

@mathesoncalum mathesoncalum assigned mathesoncalum and unassigned Eism Dec 3, 2023
This was referenced Dec 5, 2023
Merged
Merged
RomanPudashkin added a commit that referenced this issue Dec 8, 2023
@RomanPudashkin
Merge pull request #20316 from mathesoncalum/20233-msbasic_menu_ticks…
1b91b76 
…-430

Fix #20233: Ensure correct checkmarks are displayed for MS Basic menu (4.3.0)
RomanPudashkin added a commit that referenced this issue Dec 8, 2023
@RomanPudashkin
Merge pull request #20317 from mathesoncalum/20233-msbasic_menu_ticks…
e40d212 
…-420

Fix #20233: Ensure correct checkmarks are displayed for MS Basic menu (4.2.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mathesoncalum mathesoncalum

Labels
Design debt To be used for small bits of jank that shouldn't take much developer time to fix mixer Issues relating to the Mixer UI Visual issues affecting the UI (not notation)
Projects
MuseScore 4.2
Status: Done
Milestone
No milestone
3 participants
@Eism @avvvvve @mathesoncalum