Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drumset preview pane not showing correct stem direction #20785

Closed
henkdegroot opened this issue Jan 1, 2024 · 1 comment · Fixed by #20879
Closed

Drumset preview pane not showing correct stem direction #20785

henkdegroot opened this issue Jan 1, 2024 · 1 comment · Fixed by #20879
Assignees
@Eism
Labels
P2 Priority: Medium regression MS3 Regression from MS3 (3.6.2) regression MS4 Regression on a prior release UI Visual issues affecting the UI (not notation)

Comments

@henkdegroot
Copy link

Issue type

UI bug (incorrect info or interface appearance)

Bug description

The drumset preview window is not showing the stems in the selected direction, as set in the drumset settings.
All stems are shown in the Up direction.
Also when Editting the drumset, the preview of the note in that dialog is not showing the selected stem direction.

Steps to reproduce

  1. Start a New Score

  2. Select the Drumset as instrument

  3. Start Note Entry (this will show the Drumset window)

  4. Check the content of the window:
    drumset-view

  5. Click Edit drumset

  6. Select the Bass Drum 1
    drumset-view-bassdrum

Screenshots/Screen recordings

No response

MuseScore Version

4.2

Regression

Yes, this used to work in MuseScore 3.x and now is broken

Operating system

Windows 11

Additional context

No response
@muse-bot muse-bot added regression MS3 Regression from MS3 (3.6.2) UI Visual issues affecting the UI (not notation) labels Jan 1, 2024
@MarcSabatella
Copy link
Contributor

Also a regression vs 4.1.1 - it worked correctly there.

@oktophonie oktophonie added regression MS4 Regression on a prior release P2 Priority: Medium labels Jan 2, 2024
@MarcSabatella MarcSabatella mentioned this issue Jan 5, 2024
Open
Eism added a commit to Eism/MuseScore that referenced this issue Jan 8, 2024
@Eism
fixed musescore#20785: Compute up before drawing
200b7e0
@Eism Eism mentioned this issue Jan 8, 2024
Merged
RomanPudashkin added a commit that referenced this issue Jan 8, 2024
@RomanPudashkin
Merge pull request #20879 from Eism/drumset_stem_up_fix
c9ddf64 
fixed #20785: Drumset preview pane not showing correct stem direction
RomanPudashkin pushed a commit to RomanPudashkin/MuseScore that referenced this issue Jan 9, 2024
@Eism @RomanPudashkin
fixed musescore#20785: Compute up before drawing
06ff0f8
RomanPudashkin pushed a commit to RomanPudashkin/MuseScore that referenced this issue Jan 9, 2024
@Eism @RomanPudashkin
fixed musescore#20785: Compute up before drawing
63e6dfa
zacjansheski pushed a commit to zacjansheski/MuseScore that referenced this issue Feb 13, 2024
@Eism @zacjansheski
fixed musescore#20785: Compute up before drawing
bef78cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Eism Eism

Labels
P2 Priority: Medium regression MS3 Regression from MS3 (3.6.2) regression MS4 Regression on a prior release UI Visual issues affecting the UI (not notation)
Projects
No open projects
MuseScore 4.2.1
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixed #20785: Drumset preview pane not showing correct stem direction Eism/MuseScore
5 participants
@MarcSabatella @Eism @henkdegroot @muse-bot @oktophonie