Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing velocity of one note also changes the velocity for notes sharing a beam #21285

Closed
NicolaRulli opened this issue Jan 29, 2024 · 13 comments · Fixed by #22838
Closed

Changing velocity of one note also changes the velocity for notes sharing a beam #21285

NicolaRulli opened this issue Jan 29, 2024 · 13 comments · Fixed by #22838
Assignees
Labels
P2 Priority: Medium playback General playback issue UX/interaction

Comments

@NicolaRulli
Copy link

NicolaRulli commented Jan 29, 2024

Issue type

UX/Interaction bug (incorrect behaviour)

Bug description

If using box (shift) selection to change the velocity of one note, all the other notes in the tuplet will also adopt that change.

Steps to reproduce

  1. create a score
  2. create a triplet
  3. select a note in "box"/area mode by shift clicking it, or by clicking it then pressing shift right followed by shift left
  4. open the playback submenu in the properties panel
  5. change the velocity value
  6. click on any of the other notes, which you hadn't selected until now
  7. check the velocity value: it will be equal to that you have set for the other note, instead of being the default

Screenshots/Screen recordings

No response

MuseScore Version

OS: Windows 10 Version 2009 or later, Arch.: x86_64, MuseScore version (64-bit): 4.2.1-240230937, revision: github-musescore-musescore-d757433

Regression

I don't know

Operating system

Windows 10 home x64

Additional context

No response

@bkunda bkunda added the needs info More information is required before action can be taken label Jan 30, 2024
@zacjansheski

This comment was marked as resolved.

@NicolaRulli
Copy link
Author

I make a range selection of ONE note (or chord, or vertically aligned notes/chords across different staves) and the whole tuplet gets affected, even though only ONE of its elements is selected (in actual user selection, in box size, and in blue highlighting)

@zacjansheski

This comment was marked as resolved.

@zacjansheski
Copy link
Contributor

zacjansheski commented Jan 30, 2024

Got it now, looks like the notes need to be beamed together

video1696877519.mp4

@zacjansheski zacjansheski added P2 Priority: Medium and removed needs info More information is required before action can be taken labels Jan 30, 2024
@NicolaRulli
Copy link
Author

That's an interesting discriminating factor. Next time I encounter a bug on notes beamed together, I'll make sure to check whether it also applies to beamless notes.

@NicolaRulli
Copy link
Author

Update: it's actually ONLY a matter of beam, not of tuplet. The same happens for any two beamed eighth notes, for example.

@cbjeukendrup
Copy link
Contributor

Yes, when you select a beam, the Properties panel will pretend you have selected all notes under that beam. That's partially by design, but also has unexpected consequences, like this one.

@zacjansheski zacjansheski changed the title Changing velocity of one note in a tuplet, in some scenarios, will change that of the whole tuplet Changing velocity of one note also changes the velocity for notes sharing a beam Jan 31, 2024
@NicolaRulli
Copy link
Author

I just found that the beams also prevent mass-adjustment of Y position, even if all notes on the beam are selected. I'll make a separate issue later if I have time, but this makes me think it's the same underlying problem, and it's probably a regression because I imagine I should have noticed this one earlier (when finnicking with the slash notation cues) if it had been present.

@bkunda bkunda added the playback General playback issue label Feb 3, 2024
@NicolaRulli
Copy link
Author

Additional interesting interaction between two bugs:
Selecting an area that includes beams will prevent editing the Y position field even thought there may be non-beamed and non-note contents, however changing any of the other fields will still reset all Y positions to default due to the bug that causes all other fields to reset to default upon mass edits to one field, so the beam just disables input in the UI field but it doesn't protect the underlying value from changes from other sources.

@mathesoncalum
Copy link
Contributor

Like you say @cbjeukendrup this seems partially by design. My suggestion would be to only apply playback changes to notes whose heads are currently selected. The "trade-off" is that selecting stems/beams only will return a greyed-out playback button (see below) but, to me at least, this actually makes more sense than the current behaviour.

@bkunda any thoughts?

Screenshot 2024-04-29 at 15 33 33

@mathesoncalum mathesoncalum added the needs design Design is needed label Apr 29, 2024
@cbjeukendrup
Copy link
Contributor

That makes much more sense to me too. When the user selects a beam or stem specifically, they are probably doing so on purpose, and a beam or stem doesn't really seem to have any association with playback.

@bkunda
Copy link

bkunda commented May 15, 2024

Agreed. At least conceptually, beams don't trigger playback events – but noteheads do.

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented May 15, 2024

Apparently a regression vs. Mu3

RomanPudashkin added a commit that referenced this issue May 16, 2024
…ties

Fix #21285: Only apply playback changes to notes with head selected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Priority: Medium playback General playback issue UX/interaction
Projects
Development

Successfully merging a pull request may close this issue.

8 participants