Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Accidental Alterations on Ornaments in MusicXML Export (also Import?) #22229

Closed
millsj1134 opened this issue Apr 5, 2024 · 11 comments · Fixed by #21364
Closed

Support for Accidental Alterations on Ornaments in MusicXML Export (also Import?) #22229

millsj1134 opened this issue Apr 5, 2024 · 11 comments · Fixed by #21364
Labels
feature request Used to suggest improvements or new capabilities MusicXML

Comments

@millsj1134
Copy link

Your idea

Hi there, I noticed when exporting a MusicXML from Musescore 4 that any alteration done to ornaments (either above or below) do not show up in the XML file. This is something I would like if it is possible, please.
image

I will attach files for the above example below:
Archive.zip

Here is the MusicXML 4.0 documentation for how this should look in the XML once completed:
image

Please let me know if you have any questions about this.

Problem to be solved

It would allow any "accidental alterations" to an ornament to be visible in the MusicXML export. If the import was also done, then Musescore 4 would also recognize this information.

Prior art

N/A

Additional context

N/A

@muse-bot muse-bot added the feature request Used to suggest improvements or new capabilities label Apr 5, 2024
@Jojo-Schmitz
Copy link
Contributor

Stems from https://musescore.org/en/node/362367 and yes, import is not working either

@rettinghaus
Copy link
Contributor

already fixed in #21364

@Jojo-Schmitz
Copy link
Contributor

Not the import though, unless I miss something?

@rettinghaus
Copy link
Contributor

@Jojo-Schmitz Correct, but that part is more or less a copy of #19764.

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Apr 9, 2024

Also it doesn't seem to export the placement

@rettinghaus
Copy link
Contributor

Then it seems you need to have another look.

@millsj1134
Copy link
Author

already fixed in #21364

I referenced this issue. It seems it might have been committed but I cannot understand all the lingo. Has this made it to production yet? I'd be happy to test it if that's helpful. Maybe I need to be on beta? 🤔

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Apr 9, 2024

Then it seems you need to have another look.

Ahh, it is "hidden" in writeAccidental()

Has this made it to production yet? I'd be happy to test it if that's helpful. Maybe I need to be on beta?

If #22286 gets merged, it'll be in the upcomming 4.3.0, else you need a nightly build from master (sort of an Alpha)

@millsj1134
Copy link
Author

millsj1134 commented Apr 9, 2024

else you need a nightly build from master (sort of an Alpha)

I would be happy to do this. Might need a bit of guidance but if me using this could help I would be happy to do it. Your call

@Jojo-Schmitz
Copy link
Contributor

I would be happy to do this. Might need a bit of guidance but if me using this could help I would be happy to do it. Your call

See https://github.com/musescore/MuseScore/wiki/Downloading-and-running-test-builds

@millsj1134
Copy link
Author

See https://github.com/musescore/MuseScore/wiki/Downloading-and-running-test-builds

Thank you so much! So cool to see the infrastructure you all have built for this!! 😊

RomanPudashkin added a commit that referenced this issue Apr 9, 2024
Fix #22229:  export ornament accidentals to MusicXML
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Used to suggest improvements or new capabilities MusicXML
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

6 participants