Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU4 Issue] Help > About... Replace link to donate page, change text, say GPL version, say build etc. #7970

Closed
vshalkevich opened this issue Apr 17, 2021 · 8 comments · Fixed by #7988
Labels
P2 Priority: Medium

Comments

@vshalkevich
Copy link

vshalkevich commented Apr 17, 2021

Describe the bug
About MuseScore pop-up content is missed

To Reproduce
Steps to reproduce the behavior:

  1. Click on "Help" (from the Upper Menu)
  2. Click on 'About...'
  3. Check About MuseScore pop-up links and text

Expected behavior

  1. Replace link to donate page with link to contribute page and rephrase to "Help with MuseScore's development".
  2. musescore.org link should take you to that page, not musescore.org/en-GB etc. (it should take to the user's language page)
  3. Should say GPL version (soon to be GPL 3)
  4. should say "development build", "nightly build" or similar (and build version)

Desktop (please complete the following information):
MacOS
Windows 10

@vshalkevich vshalkevich added the P2 Priority: Medium label Apr 17, 2021
@vshalkevich vshalkevich added this to To do in [MU4.0 - TOP_MENU_BAR] via automation Apr 17, 2021
@vshalkevich vshalkevich changed the title [MU4 Issue] Replace link to donate page and change it`s text [MU4 Issue] Help > About... Replace link to donate page, change it`s text, say GPL version, say build etc. Apr 17, 2021
@RobFog
Copy link

RobFog commented Apr 17, 2021

"it`s" → its

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Apr 17, 2021

Which URL exactly should the contribute link point to? It IMHO should be the user's language, but https://musescore.org/contribute doesn't redirect properly (it does redirect to https://musescore.org/en/contribute, unconditionally) and e.g. https://musescore.org/de/contribute doesn't exist, it is https://musescore.org/de/unterstuetzung in that case. We may need help of the website to redirect appropriatly.
Which word should be shown for the link, "development", or "Help"?

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this issue Apr 17, 2021
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this issue Apr 17, 2021
@vshalkevich vshalkevich changed the title [MU4 Issue] Help > About... Replace link to donate page, change it`s text, say GPL version, say build etc. [MU4 Issue] Help > About... Replace link to donate page, chang text, say GPL version, say build etc. Apr 17, 2021
@vshalkevich vshalkevich changed the title [MU4 Issue] Help > About... Replace link to donate page, chang text, say GPL version, say build etc. [MU4 Issue] Help > About... Replace link to donate page, change text, say GPL version, say build etc. Apr 17, 2021
@vshalkevich
Copy link
Author

Need to detail information
@shoogle Could you look at Expected result and add information:
Which URL exactly should the contribute link point to?
Which word should be shown for the link, "development", or "Help"?

@shoogle
Copy link
Contributor

shoogle commented Apr 19, 2021

@vshalkevich, the link should always point to https://musescore.org/contribute and we should fix the website to do the redirection to translated pages such as https://musescore.org/de/mitwirken based on the user's browser settings.

@Jojo-Schmitz, the link above appears to be the German page though the translation is barely started. Let me know if you can/cannot edit that page.

Here is the current About dialog:

image

Let's change the following:

Visit www.musescore.org for new versions and more information.
Support MuseScore with your contribution.

To:

Visit www.musescore.org for new versions and more information.
Get help with the program or contribute to its development.

with links to https://musescore.org/forum and https://musescore.org/contribute.

It should also say:

Version: 4.0.0 development build

or "nightly build", and:

Published under the GNU General Public License version 3.

with link to https://www.gnu.org/licenses/gpl-3.0.html.

@shoogle
Copy link
Contributor

shoogle commented Apr 19, 2021

@vshalkevich, BTW, don't feel you have to obey the issue template religiously if it makes more sense to do something else. E.g. "Help > About looks like [...], it should look like [...]." would be fine for this issue.

@Jojo-Schmitz
Copy link
Contributor

I can translate that https://musescore.org/de/mitwirken

Running into a bit of a problem with getting the requested changes done for master (the interaction of cpp and qml is foreign to me), so created a 3.x PR first.

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this issue Apr 20, 2021
…ge text, say GPL version, say build etc.

and keep HTML out of translatable text as far as possible
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this issue Apr 20, 2021
…ge text, say GPL version, say build etc.

and keep HTML out of translatable text as far as possible
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this issue Apr 20, 2021
…ge text, say GPL version, say build etc.

and keep HTML out of translatable text as far as possible
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this issue Apr 20, 2021
…ge text, say GPL version, say build etc.

and keep HTML out of translatable text as far as possible
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this issue Apr 20, 2021
…ge text, say GPL version, say build etc.

and keep HTML out of translatable text as far as possible
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this issue Apr 21, 2021
…ge its text, say GPL version

Fixes issue musescore#7970 for the 3.x branch
@vshalkevich
Copy link
Author

I can translate that https://musescore.org/de/mitwirken

Running into a bit of a problem with getting the requested changes done for master (the interaction of cpp and qml is foreign to me), so created a 3.x PR first.

Sounds good. I think it is a good idea

@Jojo-Schmitz
Copy link
Contributor

Both PRs, for 3.x and master, are ready

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this issue Apr 22, 2021
…ge its text, say GPL version

Fixes issue musescore#7970 for the 3.x branch
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this issue Apr 26, 2021
…ge its text, say GPL version

Fixes issue musescore#7970 for the 3.x branch
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this issue Apr 26, 2021
…ge its text, say GPL version

Fixes issue musescore#7970 for the 3.x branch
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this issue Apr 28, 2021
…ge text, say GPL version, say build etc.

and keep HTML out of translatable text as far as possible
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this issue Apr 28, 2021
…ge text, say GPL version, say build etc.

and keep HTML out of translatable text as far as possible
[MU4.0 - TOP_MENU_BAR] automation moved this from To do to Done Apr 29, 2021
vpereverzev pushed a commit that referenced this issue Apr 29, 2021
…say GPL version, say build etc.

and keep HTML out of translatable text as far as possible
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this issue May 11, 2021
…ge its text, say GPL version

Fixes issue musescore#7970 for the 3.x branch
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this issue Jun 28, 2021
…ge its text, say GPL version

Fixes issue musescore#7970 for the 3.x branch
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this issue Jul 1, 2021
…ge its text, say GPL version

Fixes issue musescore#7970 for the 3.x branch
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this issue Jul 27, 2021
…ge its text, say GPL version

Fixes issue musescore#7970 for the 3.x branch
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this issue Jul 27, 2021
…ge its text, say GPL version

Fixes issue musescore#7970 for the 3.x branch
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this issue Jul 27, 2021
…ge its text, say GPL version

Fixes issue musescore#7970 for the 3.x branch
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this issue Jul 27, 2021
…ge its text, say GPL version

Fixes issue musescore#7970 for the 3.x branch
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this issue Jul 28, 2021
…ge its text, say GPL version

Fixes issue musescore#7970 for the 3.x branch
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this issue Jul 28, 2021
…ge its text, say GPL version

Fixes issue musescore#7970 for the 3.x branch
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this issue Aug 13, 2021
…ge its text, say GPL version

Fixes issue musescore#7970 for the 3.x branch
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this issue Aug 13, 2021
…ge its text, say GPL version

Fixes issue musescore#7970 for the 3.x branch
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this issue Aug 19, 2021
…ge its text, say GPL version

Fixes issue musescore#7970 for the 3.x branch
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this issue Aug 19, 2021
…ge its text, say GPL version

Fixes issue musescore#7970 for the 3.x branch
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this issue Sep 2, 2021
…ge its text, say GPL version

Fixes issue musescore#7970 for the 3.x branch
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this issue Sep 10, 2021
…ge its text, say GPL version

Fixes issue musescore#7970 for the 3.x branch
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this issue Sep 23, 2021
…ge its text, say GPL version

Fixes issue musescore#7970 for the 3.x branch
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this issue Mar 5, 2023
…ge its text, say GPL version

Fixes issue musescore#7970 for the 3.x branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Priority: Medium
Projects
No open projects
4 participants