fix whole note tremolo positions #10131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Vtests crash at generating the current PNGs, utests crash with a failed assertion. |
Nick-Mazuk
force-pushed
the
whole-note-tremolo
branch
2 times, most recently
from
30f0f64
to
3a947ef
Compare
|
Still the same assertion failure: |
Nick-Mazuk
force-pushed
the
whole-note-tremolo
branch
2 times, most recently
from
eb67f1a
to
087bfe1
Compare
change noteSide tremolo padding to 1.25 spaces fix failing tests fix small bugs fix one-note tremolo alignment on stemless chords with mirrored note
Nick-Mazuk
force-pushed
the
whole-note-tremolo
branch
from
087bfe1
to
3c07139
Compare
oktophonie
approved these changes
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Positions one-note tremolos on whole notes identically to those on stemmed notes. I also removed the magic numbers by creating two new style parameters. That way there's a single source of truth for the position for the tremolos.