Fix #26411 Don't disable inspector controls based on value difference

[briff]

I think (and have written in #26411) the way visibility flag is enabled and disabled is counter-intuitive.
Checking the code I discovered that also the "reset" button's behavior is strange (e.g. you can't reset the value of multiple selected items if they have the same value).
I believe removing the value difference check makes the best result in general and would make MuseScore work similar to other software. In special cases further enhancements could be made later (e.g. 3rd state for checkboxes).

[lasconic]

Sorry for the very long wait before any feedback...
I believe the reset button disabling is pretty cool. The fact that you can't reset the values for multiple selected items with same value is a bug and should be fixed though. Completely removing the code is a bit extreme.

Regarding the disabling of the controls if the value is different. It's indeed a bug. I would propose to gray out the controls in this case, to indicate the difference, but not to disabled it.

I will push a fix implementing the above. It would be great if you could test it and give me your opinion.

[lasconic]

see 370c9d1

[MarcSabatella]

BTW, there is also http://musescore.org/en/node/25807 that is relevant here, if people want to be looking at the reset-handling code . I think this a mixup between chord offset and note offset, if I remember correctly what I figured out from my initial investigation.

[briff]

Thank you, Nicolas. The behavior looks quite good, but the greying is confusing - it is not disabled but looks like disabled. Can you use a different color or not greying at all? (Most confusing with the Visible flag.)

[lasconic]

I could use the "selection blue", or the purple of button pressed? Any advice?
I like the idea of denoting that the displayed info is not "right", but the value of the first selected element.

[briff]

Selection blue sounds to be a great idea, as what we see is the value of the selection.