[MU4] playback_tuning #10731
[MU4] playback_tuning #10731
Conversation
…here is no appropriate API for that
| MuseScore_General.sf3 | ||
| MuseScore_General_License.md | ||
| MuseScore_General_Changelog.txt | ||
| MuseScore_General_Readme.md |
There was a problem hiding this comment.
Now that we are adding the sound font to the repo, could we also remove the downloading from the build process? (i.e. DownloadSoundFont.cmake etc.)
There was a problem hiding this comment.
I'm not sure whether adding a ~80MB binary file to the repo is a good idea. A couple years back we got rid of that and for IMHO good reason
There was a problem hiding this comment.
Now that we are adding the sound font to the repo, could we also remove the downloading from the build process? (i.e. DownloadSoundFont.cmake etc.)
let's keep them, they shouldn't run if there is already a sound-font in the "share" folder
There was a problem hiding this comment.
DownloadSoundFont.cmake rather compares the contents of the share/sound/SF_VERSION file with https://ftp.osuosl.org/pub/musescore/soundfont/MuseScore_General/VERSION.
|
Is it intentional that this really is the former HQ soundfont? Which is more than twice the size of the old MuseScore_General.sf3. |
|
@Jojo-Schmitz Yes it is. The size of the HQ sf is still acceptable, and more importantly: the soundfont is now loaded in a different way, so that only the sounds that are actually used will be loaded, not the whole soundfont. So it won't cause much more memory usage, only better and more sounds. |
No description provided.