Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

partial fix for #23324: links for section breaks, frames, & fret diagrams #1086

Merged
merged 3 commits into from
Aug 4, 2014

Conversation

MarcSabatella
Copy link
Contributor

Links for section breaks (present before parts created), frames (added after parts created) and fret diagrams (both before and after).

@MarcSabatella MarcSabatella changed the title partial fix for #23324: links for section breaks & fret diagrams partial fix for #23324: links for section breaks, frames, & fret diagrams Aug 1, 2014
@MarcSabatella
Copy link
Contributor Author

The Travis failures are the result of my changes, and I think they are correct, but not having Guitar Pro or understanding how it works, I can't say for sure if the new behavior is correct behavior or not. FWIW, I elected to include fret diagrams in the "copy to linked parts, but not to linked staves in same score" category. Meaning, if you have a score that includes a guitar instrument with two linked staves, the fret diagram will appear on only one of the staves (just like chord symbols and a handful of other element types), but will appear on the extracted part as well (again, just one the corresponding staff).

@jpirie
Copy link
Contributor

jpirie commented Aug 1, 2014

I'll have a peek at the resulting score now, I have various versions of Guitar Pro I can check this against.

@jpirie
Copy link
Contributor

jpirie commented Aug 1, 2014

Looks great to me! The failing guitar pro tests for fret diagrams should just be updated with new solutions. (This issue actually tangentially touches on the discussion I'm having on the mailing list about which staffs certain items (mailing list discussion is focused on fingering) are placed on, perhaps some users may wish this laid out only on the tab staff/only on standard notation staff/both on standard notation and tab staffs - might be nice to think about this at some point in the future.)

@MarcSabatella
Copy link
Contributor Author

Thanks! I'll update the tests later todasy.

BTW, there are two places in the code where the decisions are made about which items to duplicate and which not - in excerpt.cpp where the parts are created (if the elements exist in score already) and also in undo.cpp where elements are added (if parts have already been created). You'll see that's where I added FRET_DIAGRAM in my code here. Right now, we just just make an arbitrary decision based on element type as to which items not to duplicate, but it would presumably be a simple matter to add some sort of flag - either on a per-element basis or perhaps via a style or staff type option - to control this further. It just hasn't been a priority.

@MarcSabatella
Copy link
Contributor Author

Now it's just a general Travis error. I updated the tests and they pass for me locally.

lasconic added a commit that referenced this pull request Aug 4, 2014
partial fix for #23324: links for section breaks, frames, & fret diagrams
@lasconic lasconic merged commit 491625d into musescore:master Aug 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants