Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Staff/part properties to Instrument right-click menu #11160

Merged

Conversation

micpap25
Copy link
Contributor

Resolves #11130

Define a function that creates a specialized right-click menu for instrument names, which contains the default right-click menu options as well as "Staff/part properties" after a separator.
This implements convenient functionality from MU3 and is useful for end-users.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@RomanPudashkin
Copy link
Contributor

Please, rebase your PR. There should be only one commit

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Apr 12, 2022

(IMHO) easiest way: git rebase -i HEAD~3, then replace the "pick" of the 2nd and 3rd commit with "f", save, then git push -f

Define a function that creates a specialized right-click menu for instrument names, which contains the default right-click menu options as well as "Staff/part properties" after a separator.
@micpap25 micpap25 force-pushed the staff-properties-instrument-name branch from 263166b to 616291a Compare April 12, 2022 12:13
@micpap25
Copy link
Contributor Author

@RomanPudashkin Sorry about that, I've rebased. Thank you for the guidance @Jojo-Schmitz .

@RomanPudashkin RomanPudashkin merged commit f1b6986 into musescore:master Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MU4 Issue] Staff/part properties missing in Instrument's name context menu
3 participants