fix #29246: unrecognized chords with symbols imported with markup #1118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lasconic
added a commit
that referenced
this pull request
Aug 11, 2014
fix #29246: unrecognized chords with symbols imported with markup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I elected to fix this within the Text class as it seems the same fix could be useful elsewhere. The fix is, for Text items that contain accidentalFlat or accidentalSharp symbols, when calling plainText(noSym = true), instead of skipping those symbols entirely as we would for other symbols, I replace them with "b" and "#".
Right now, it looks like the only other place plainText(true) is used is in generating filenames for newly created scores from titles. So if you set the title of your score to "Concerto for Bb Trumpet" but with a real flat sign, this would substitute a "b" for the flat sign in the generated filename rather than leave it out entirely - a good thing, I would think.