fix #14353: lyrics and staff spacers don't work with hide empty staves #1124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de empty staves
lasconic
added a commit
that referenced
this pull request
Aug 12, 2014
fix #14353: lyrics and staff spacers don't work with hide empty staves
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes calculation of system height when there are spacers down or lyrics adding to distanceDown for a staff and the staves below are all hidden/empty. I thought maybe spacers up and/or fret diagrams would have a similar issue, but they don't - the bbox() calculation already accounts for those.
I will say I don't totally understand all the interactions between the calculations involved, and I wouldn't mind if someone reviewed this a bit to be sure I am not doing something stupid. But it does fix the problem cases, and should not change behavior if the bottom staff is not hidden.