various translation and spelling issues #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -160,33 +160,33 @@ static QString createDefaultFileName(QString fn) | |||
|
|
|||
| static bool readScoreError(const QString& name, Score::FileError error, bool ask) | |||
| { | |||
| QString msg = QString(QT_TRANSLATE_NOOP(file, "Cannot read file %1:\n")).arg(name); | |||
| QString msg = QString(QT_TRANSLATE_NOOP("file", "Cannot read file %1:\n")).arg(name); | |||
There was a problem hiding this comment.
mmm is this really going to work?
There was a problem hiding this comment.
not sure. it Needs to be a string, no idea what file is, "file" is a string and has the correct context. These strings were not on Transifex, so I assure this was a typo?
There was a problem hiding this comment.
Let's try differently, translating at assignment rather than at output, commit follows shortly...
Jojo-Schmitz
changed the title
|
The travis error is legit. See https://travis-ci.org/musescore/MuseScore/builds/32712298#L2205 |
|
I know, I wanted to see a real error for a change :-) |
and a better name for it
when changing timesig
for consistency with other "Eighth"
Is the code duplication with awl/utils.cpp really needed?
and adjust test. Some code duplication with smDrumset ?!?
and tests. Some code duplication with gpDrumset ?!?
lasconic
added a commit
that referenced
this pull request
Aug 17, 2014
various translation and spelling issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.