[MU4] Fix #331840: Crash on creating a 4-or-higher tuplet on a 512th or an 8-or-higher tuplet on a 256th #11561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It does also prevent otherwise working 4- and 5-lets on dotted 512th, but IMHO that is a rather small price to pay, isn't it? |
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
May 7, 2022
and return from creating an invalid tuplet early, this should fix https://musescore.org/en/node/331840, "Creating a 4-or-higher tuplet on a 512th or an 8-or-higher tuplet on a 256th crashes Musescore", it at least prevents the crash. It does not bring up the "Tuplet too short" dialog though, for that see musescore#11561.
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
May 7, 2022
and return from creating an invalid tuplet early, this should fix https://musescore.org/en/node/331840, "Creating a 4-or-higher tuplet on a 512th or an 8-or-higher tuplet on a 256th crashes Musescore", it at least prevents the crash. It does not bring up the "Tuplet too short" dialog though, for that see musescore#11561.
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
May 7, 2022
or an 8-or-higher tuplet on a 256th Sort of a backport of musescore#11560 (without the `std::gcd()` part) and musescore#11561.
igorkorsukov
pushed a commit
that referenced
this pull request
May 9, 2022
and return from creating an invalid tuplet early, this should fix https://musescore.org/en/node/331840, "Creating a 4-or-higher tuplet on a 512th or an 8-or-higher tuplet on a 256th crashes Musescore", it at least prevents the crash. It does not bring up the "Tuplet too short" dialog though, for that see #11561.
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
May 12, 2022
or an 8-or-higher tuplet on a 256th Sort of a backport of musescore#11560 (without the `std::gcd()` part) and musescore#11561.
Jojo-Schmitz
force-pushed
the
crash-tuplet
branch
from
03f443c
to
44bcb31
Compare
Jojo-Schmitz
force-pushed
the
crash-tuplet
branch
from
44bcb31
to
5066a7b
Compare
Merged
Jojo-Schmitz
force-pushed
the
crash-tuplet
branch
from
5066a7b
to
52c82e8
Compare
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Mar 5, 2023
or an 8-or-higher tuplet on a 256th Sort of a backport of musescore#11560 (without the `std::gcd()` part) and musescore#11561.
Jojo-Schmitz
force-pushed
the
crash-tuplet
branch
from
52c82e8
to
3516ccb
Compare
Jojo-Schmitz
force-pushed
the
crash-tuplet
branch
from
3516ccb
to
df5cbb6
Compare
or an 8-or-higher tuplet on a 256th
Jojo-Schmitz
force-pushed
the
crash-tuplet
branch
from
df5cbb6
to
7614b39
Compare
|
Seems not needed anymore and doesn't have the restrictions mentioned further up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/331840
Applies to 3.x too.