Improve TAB fretting algorithm. #1160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An attempt to improve the current implementation to better deal with the case in forum post #29876 and possibly even with less specialized cases. Changes: - when a note changes of pitch, its fretting is discarded before any fretting - each note not yet fretted is sorted for fretting as belonging to the string most convenient for it. This affects the order in which notes are evaluated during fretting. Note: the algorithm can still be fooled by casual note entry and by changing note pitches by large intervals (octave), but it seems anyway better than before.
mgavioli
changed the title
mgavioli
added a commit
that referenced
this pull request
Aug 21, 2014
Improve TAB fretting algorithm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to improve the current implementation to better deal with the case in forum post #29876 and possibly even with less specialized cases.
Changes:
These changes mostly affect the order in which notes are evaluated during fretting.
Note: the algorithm can still be fooled by casual note entry and by changing note pitches by large intervals (octave), but it seems anyway better than before.