Accidentals xml #1173
Merged
Accidentals xml #1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…accidental tag is missing
… by Sibelius 7.5)
|
Let's gather feedback from actual users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #17508 and it should take care of software compatibility. I tested the export/import against a demo version of Sibelius 7.5.
Because of the way Sibelius exports microtonal accidentals to MusicXml, I had to partially rewrite my previous PR (which in the meantime got merged): sorry for the previous almost superfluous PR. It seems that Sibelius rounds the "alter" value to integer, determining (in the previous PR) a wrong import in MuseScore of 3/4 tone accidentals. Now it should work as expected.
I couldn't install the Dolet plugin (it does not seem to work with a demo), so I don't know if it exports better MusicXml files.
If someone owns a copy of Finale and/or Sibelius with Dolet, could she/he please test the import/export? (Actually, in the Sibelius Demo I could only enter 1/4 and 3/4 tone accidentals; these are now properly handled)