partial fix for #19197 - get barline length right #1207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wschweer
added a commit
that referenced
this pull request
Aug 23, 2014
partial fix for #19197 - get barline length right
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.3 scores with staves of fewer or more than 5 lines are imported with incorrect barline liengths. This fixes that. So 1-line percussion staves should import well.
3-line drum sets are another matter. In 1.3, these had a staff spacing of 2sp. I have identified the place where we could potentially preserve this and I have implemented the change. But it is commented out here, as it doesn't actually produce the correct results since the drum notes (and rest) would need to be moved to two lines down in order for this to produce similar layout as 1.3.