[MU4] Fix typo, including compatibility check #12133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jojo-Schmitz
force-pushed
the
pedalListStyle
branch
from
3ce7ecd
to
8a20aa4
Compare
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jun 22, 2022
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jun 22, 2022
Jojo-Schmitz
changed the title
Jojo-Schmitz
force-pushed
the
pedalListStyle
branch
from
8a20aa4
to
cfe3eb3
Compare
Jojo-Schmitz
force-pushed
the
pedalListStyle
branch
from
cfe3eb3
to
05cd10f
Compare
|
No idea why, after a needed rebase to resolve a merge conflict, it now fails the vtests? Edit: fixed. |
cbjeukendrup
reviewed
Aug 1, 2022
Jojo-Schmitz
force-pushed
the
pedalListStyle
branch
2 times, most recently
from
98b1e2f
to
1cd7783
Compare
Jojo-Schmitz
force-pushed
the
pedalListStyle
branch
from
1cd7783
to
cba80cd
Compare
Jojo-Schmitz
force-pushed
the
pedalListStyle
branch
from
cba80cd
to
890fd4c
Compare
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Feb 11, 2023
This reverts commit 5b30d14, backport of musescore#12133. Causes issues when reading scores containing "pedalLineStyle" with earlier 3.x releases
|
Maybe to late to merge this into master now, as it'd cause 4.0.0 and 4.0.1 to not read that setting properly. |
7 tasks
|
Yeah, that's a good point... I've added it to the list of things to consider when changing the file format, so that we won't forget about it again. |
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Mar 5, 2023
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Mar 5, 2023
This reverts commit 5b30d14, backport of musescore#12133. Causes issues when reading scores containing "pedalLineStyle" with earlier 3.x releases
igorkorsukov
approved these changes
May 10, 2023
|
This does need the format version change though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same issue with MU3