Accessibility: Improve speech output for notes and common elements #12340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoogle
force-pushed
the
accessibility-element-info
branch
from
e81c0bf
to
533f291
Compare
shoogle
force-pushed
the
accessibility-element-info
branch
from
533f291
to
1ae3de3
Compare
|
Tested working with NVDA, Narrator, VoiceOver, Orca. For testing purposes, use Ctrl+Shift+Up or Ctrl+Shift+Down to move some notes across staves, then make the note invisible or change the notehead shape via the Properties panel.
Create a custom tuplet with 10 or more notes via: And check speech output for the above. |
Eism
reviewed
Jul 11, 2022
shoogle
force-pushed
the
accessibility-element-info
branch
from
e2cc066
to
93067d2
Compare
Screen readers will now announce: - [Fix #312625] Notehead group type (e.g. "cross", "triangle", etc.). - [Fix #312628] When notes or rests use cross-staff notation. - [Fix #312627] When elements are invisible. - [Fix #307442] Tuplet length for custom tuplets (more than 9 notes). Also speeds up speech output by stripping some punctuation from element names to prevent unnecessary pauses.
shoogle
force-pushed
the
accessibility-element-info
branch
from
93067d2
to
52be682
Compare
Eism
approved these changes
Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen readers will now announce:
Accidentals in note names (e.g. "A♯", "B♭", etc.).
[Fix MU#312625] Notehead group type (e.g. "cross", "triangle", etc.).
[Fix MU#312628] When notes or rests use cross-staff notation.
[Fix MU#312627] When elements are invisible.
[Fix MU#307442] Tuplet length for custom tuplets (more than 9 notes).
Replaces PR #8877.