fixed #11492: Renamed MuseScore_General to MS Basic #12398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomanPudashkin
approved these changes
Jul 14, 2022
|
Wouldn't we also need to rename it on the server where it is downloaded from? https://ftp.osuosl.org/pub/musescore/soundfont/MuseScore_General/ (Or shouldn't we rather get rid of that whole download process (which in fact is already never executed), now that the files are in the repo?) (Although I'm not entirely sure that it's good to have those huge files in the repo, because every time I push a change related to that file, GitHub complains that it doesn't like files of this size.) |
Eism
force-pushed
the
musescore_general_rename
branch
from
9490701
to
d826f03
Compare
Eism
force-pushed
the
musescore_general_rename
branch
2 times, most recently
from
956b2a7
to
9636c6d
Compare
Eism
force-pushed
the
musescore_general_rename
branch
from
9636c6d
to
cdf6f27
Compare
|
Tested #11492 on Win10, Mac12, LinuxMint 20.2 - DONE |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #11492