Extending minimum tie length implementation to apply at start of system #12451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-spa
force-pushed
the
minTieLengthExtended
branch
from
e69d004
to
b90cbe1
Compare
oktophonie
approved these changes
Jul 18, 2022
mike-spa
changed the title
src/engraving/libmscore/tie.cpp
Outdated
| endNote->addLineAttachPoint(ups(Grip::END).pos(), tie()); | ||
| } | ||
| startNote->addLineAttachPoint(ups(Grip::START).pos(), tie()); | ||
| endNote->addLineAttachPoint(ups(Grip::END).pos(), tie()); |
There was a problem hiding this comment.
Is the null-check no longer needed here?
There was a problem hiding this comment.
Good point. In principle, the null-check isn't strictly necessary, because startNote and endNote are never null. But I think it's safer if I null-check anyway, just in case we encounter a broken tie or something. I'll quickly fix this
clean up ccorrection clean correction
mike-spa
force-pushed
the
minTieLengthExtended
branch
from
b90cbe1
to
9b71ab6
Compare
RomanPudashkin
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, minimum tie length is only enforced between adjacent chords. That was by design in my first implementation. @oktophonie pointed out that it can be necessary to enforce it also at the start of a system. That case requires special handling, which is now implemented.
Additionally, the space between the end of the header and the start of the tie (which used to be determined by an anonimous variable set to 1 sp) has been moved into a dedicated style setting (though not exposed in UI).
Before:
After
