fix #31301: alignment of half notes #1254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lasconic
added a commit
that referenced
this pull request
Sep 3, 2014
fix #31301: alignment of half notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the issue thread, there were two possible solutions. The one I chose was to include half notes in the centering that had already been implemented for whole notes and larger values. This was actually just a change of a single constant - the threshold beyond which centering should take place. The other solution I considered was to remove the centering from all of these and instead go with left alignment for oversize notes - this is what most others do. I left comments in the code showing how to do this - it's quite simple, actually. So we can switch to that behavior any time we want, even make it a style option :-)