fix #32391: center lyrics under whole notes #1286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wouldn't this also be the spot where a fix for #17190 (Non-last lyric syllables on slurred/tied notes are centered rather than left aligned) would belong? |
|
Yes, I believe so - thanks for reminding me of this issue. |
|
Closing to add vtest, fix possible issue with lyric under list, and look at hyphen issue |
|
I added support for left-aligning hyphenated melismas and vtests for both fixes. |
MarcSabatella
force-pushed
the
32391-lyric-center
branch
from
3f4731e
to
0188116
Compare
|
Could you rebase? |
MarcSabatella
force-pushed
the
32391-lyric-center
branch
from
0188116
to
cfca276
Compare
lasconic
added a commit
that referenced
this pull request
Sep 11, 2014
fix #32391: center lyrics under whole notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.