fix #31571: key sig for new transposing instrument #1306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wschweer
added a commit
that referenced
this pull request
Oct 13, 2014
fix #31571: key sig for new transposing instrument
abdulazizali77
added a commit
to abdulazizali77/MuseScore
that referenced
this pull request
Jan 16, 2022
-initial ui and enum changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the listed issue without changing anything else about the management of key signatures. Which is to say, it leaves a mess in the case of scores in "C". Sometimes there will be initial "C" key signatures, sometimes there will not, depending on what you do and the order you do it in.
I figure, let's fix this bug now - the code should be good regardless of what we do later (at worst, it will turn out to be a little unnecessary insurance.