Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #33081: acoustic bass channel info #1309

Merged
merged 1 commit into from
Nov 17, 2014
Merged

fix #33081: acoustic bass channel info #1309

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion share/instruments/instruments.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8783,7 +8783,7 @@
<genre>common</genre>
</Instrument>
<Instrument id="acoustic-bass">
<!-- Same instrument as the orchestral contrabass, but used dy default plucked, rather than bowed
<!-- Same instrument as the orchestral contrabass, but used by default plucked, rather than bowed
can't init from it, as it has not been read yet. -->
<longName>Acoustic Bass</longName>
<shortName>Bass</shortName>
Expand All @@ -8803,6 +8803,12 @@
<Channel>
<program value="32"/>
</Channel>
<Channel name="arco">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get it. 43 and 44 are tremolo and pizz strings no? Why associating them to arco and tremolo?

There are other Bass technics in MIDI
32 Acoustic Bass
33 Electric Bass (finger)
34 Electric Bass (pick)
35 Fretless Bass
36 Slap Bass 1
37 Slap Bass 2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The difference between 0-based and 1-based patch numbering might be getting in the way here. I'm just using the same numbering scheme as elsewhere in instruments.xml. 43 is the patch used for the "contrabass" instrument in its default channel, and 32 is the patch number used for the "pizz" channel. This is 0-based numbering. In the 1-based numbering you see in most published charts, that's "44 Contrabass" and "33 Acoustic Bass" respectively. We were already using 32 (=33-1) as the default channel for "Acoustic Bass", and that's correct. I just needed to add 43 (=44-1) for the arco sound - and 44 (=45-1) for tremolo, so Contrabass and Acoustic Bass have the exact same channels just with a different default.

Now I'm confusing myself, but as far as I can tell, I got it right. The three patch numbers in question (0-based) are 32 for plucked, 43 for bowed, and 44 for tremolo. For the "contrabass" instrument, 43 is the default and is unnamed; 32 is available as "pizzicato". For the "acoustic bass" instrument, 32 is the default and 43 is available as "arco". This is exactly as it was in 1.3; I'm just restoring that behavior, as for some reason the arco and tremolo options got omitted.

<program value="43"/>
</Channel>
<Channel name="tremolo">
<program value="44"/>
</Channel>
<genre>common</genre>
<genre>jazz</genre>
</Instrument>
Expand Down