Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style default tweaks #13496

Merged
merged 1 commit into from
Sep 27, 2022
Merged

Conversation

mike-spa
Copy link
Contributor

@mike-spa mike-spa commented Sep 26, 2022

No functional changes, just tweaked a bunch of style defaults following @oktophonie 's specifications.

letRingLineWidth


letRingDashLineLen and letRingDashGapLen


palmMute


slurEndWidth


bracketDistance and akkoladeWidth


ledgerLineLength


Gradual tempo change should have the same baseline as tempo text


Revert "Gradual tempo change should have the same baseline as tempo text"

This reverts commit dcc064f.
@oktophonie oktophonie added the vtests This PR produces approved changes to vtest results label Sep 26, 2022
@cbjeukendrup
Copy link
Contributor

There are more .mss files across the repo that might need updating though. For example, if I search for <lyricsMinBottomDistance>2</lyricsMinBottomDistance> in the whole repo, I get 119 results, not only those 41 templates. Shouldn't the others be updated too?

@mike-spa
Copy link
Contributor Author

@cbjeukendrup If I search for the style key in .mss files in the repo I only find the legacy default specifications, which shouldn't be changed, and the utests, which I also don't think should be changed (and they're mostly playback tests anyway).

image

@RomanPudashkin RomanPudashkin merged commit 1ed939c into musescore:master Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vtests This PR produces approved changes to vtest results
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants